From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24580: 25.2.50; query-replace history doesn't work Date: Mon, 03 Oct 2016 10:16:28 +0300 Message-ID: <83h98tq4vn.fsf@gnu.org> References: <87fuogh8mo.fsf@mbork.pl> <83y428lawc.fsf@gnu.org> <20161002041715.GA5612@holos.localdomain> <8337kfkzcd.fsf@gnu.org> <20161002165128.GA1032@holos.localdomain> <20161003010843.GA2404@holos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1475479054 18775 195.159.176.226 (3 Oct 2016 07:17:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Oct 2016 07:17:34 +0000 (UTC) Cc: mbork@mbork.pl, 24580@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 03 09:17:30 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxUv-0002Ry-Rn for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Oct 2016 09:17:13 +0200 Original-Received: from localhost ([::1]:34406 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxUu-0005x4-By for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Oct 2016 03:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxUo-0005wv-1D for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqxUk-0005kd-RU for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxUk-0005kR-Ns for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqxUk-0000yg-H1 for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2016 07:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24580 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24580-submit@debbugs.gnu.org id=B24580.14754789873699 (code B ref 24580); Mon, 03 Oct 2016 07:17:02 +0000 Original-Received: (at 24580) by debbugs.gnu.org; 3 Oct 2016 07:16:27 +0000 Original-Received: from localhost ([127.0.0.1]:42481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxUB-0000xb-Ec for submit@debbugs.gnu.org; Mon, 03 Oct 2016 03:16:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxUA-0000xN-Ae for 24580@debbugs.gnu.org; Mon, 03 Oct 2016 03:16:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqxU2-0005Fy-5s for 24580@debbugs.gnu.org; Mon, 03 Oct 2016 03:16:21 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxU2-0005F6-2q; Mon, 03 Oct 2016 03:16:18 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4997 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqxTz-0000r7-N4; Mon, 03 Oct 2016 03:16:16 -0400 In-reply-to: <20161003010843.GA2404@holos.localdomain> (message from Mark Oteiza on Sun, 2 Oct 2016 21:08:43 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123943 Archived-At: > Date: Sun, 2 Oct 2016 21:08:43 -0400 > From: Mark Oteiza > Cc: mbork@mbork.pl, 24580@debbugs.gnu.org > > > > > The problem lies (at least) in query-replace-read-from, where > > > > query-replace-from-to is let bound, and later read-from-minibuffer > > > > refers to the symbol 'query-replace-from-to. At first sight, it looks > > > > like it could be fixed by putting some of the setup done by these > > > > bindings into the minibuffer setup hook. > > > > > > Isn't there a less intrusive change to fix this? A significant change > > > like the one you propose is more risky, but if there's no safer one, I > > > guess we should take it. > > > > Perhaps just adding a (defvar query-replace-from-to-history …) will be > > sufficient. That read-from-minibuffer and friends' HIST argument can > > only be a symbol is a bit frustrating. > > Surely there is a better way. Isn't this exactly the minibuffer setup hook method that I wanted to avoid? Does a simple defvar you suggested before not work? Thanks.