From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24640: Crashes in 25.1 Date: Wed, 12 Oct 2016 13:31:05 +0300 Message-ID: <83h98hc106.fsf@gnu.org> References: <83int3idxl.fsf@gnu.org> <83mviehq0p.fsf@gnu.org> <83eg3qhn29.fsf@gnu.org> <83vax2f1e5.fsf@gnu.org> <83r37pg7zl.fsf@gnu.org> <83y41wenld.fsf@gnu.org> <834m4kduzl.fsf@gnu.org> <831szodsus.fsf@gnu.org> <83zimccbzr.fsf@gnu.org> <83lgxvcd10.fsf@gnu.org> <83k2dfc4ya.fsf@gnu.org> <83bmyqdewf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1476268356 28726 195.159.176.226 (12 Oct 2016 10:32:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Oct 2016 10:32:36 +0000 (UTC) Cc: 24640@debbugs.gnu.org, rrt@sc3d.org To: phillip.lord@russet.org.uk, Toby S. Cubitt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 12 12:32:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buGpg-0005hg-U2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Oct 2016 12:32:21 +0200 Original-Received: from localhost ([::1]:60606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buGpf-0006bf-LB for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Oct 2016 06:32:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buGpU-0006a5-ET for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:32:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buGpO-0005uj-5W for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:32:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buGpO-0005uf-3N for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1buGpN-0008D0-Vs for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Oct 2016 10:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24640 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24640-submit@debbugs.gnu.org id=B24640.147626829231518 (code B ref 24640); Wed, 12 Oct 2016 10:32:01 +0000 Original-Received: (at 24640) by debbugs.gnu.org; 12 Oct 2016 10:31:32 +0000 Original-Received: from localhost ([127.0.0.1]:52758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buGot-0008CH-Ti for submit@debbugs.gnu.org; Wed, 12 Oct 2016 06:31:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buGos-0008C5-Nu for 24640@debbugs.gnu.org; Wed, 12 Oct 2016 06:31:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buGoi-0005Z6-MP for 24640@debbugs.gnu.org; Wed, 12 Oct 2016 06:31:25 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buGoi-0005Yd-Jk; Wed, 12 Oct 2016 06:31:20 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2778 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1buGof-0000rb-I8; Wed, 12 Oct 2016 06:31:18 -0400 In-reply-to: <83bmyqdewf.fsf@gnu.org> (message from Eli Zaretskii on Tue, 11 Oct 2016 19:33:20 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124381 Archived-At: > Date: Tue, 11 Oct 2016 19:33:20 +0300 > From: Eli Zaretskii > Cc: 24640@debbugs.gnu.org > > > ​Yes, the crashes appear to stop when I comment out (global-undo-tree-mode) in vars.el. > > OK, so we have our prime suspect. Can you tell where I can find the > exact version of undo-tree-mode you are using? > > Phillip, could you please look into that package and see if you can > spot any potential problems with the Emacs 25 undo internals? TIA. Some functions in undo-tree refer to or manipulate Emacs undo internals: undo-list-pop-changeset undo-list-transfer-to-tree undo-list-rebuild-from-tree undo-tree-pull-undo-in-region-branch undo-tree-pull-redo-in-region-branch undo-tree-adjust-elements-to-elt undo-tree-apply-deltas undo-tree-undo-1 undo-tree-redo-1 Do they perhaps need some adjustments to Emacs 25's undo? Another potential issue is the new undo timer we have in Emacs 25 (see undo-auto--boundary-ensure-timer in simple.el). One way of checking whether this is related to the crashes is to modify that function to use a much larger value for the 1st argument of run-at-time, say 10000, so that the undo timer never fires during the startup. Reuben, could you try that?