From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24766: 26.0.50: [PATCH] Confusing behaviour for indent-relative-maybe Date: Sat, 22 Oct 2016 22:48:32 +0300 Message-ID: <83h984p3lb.fsf@gnu.org> References: <8760ok8ays.fsf@gmail.com> <83lgxgp4ts.fsf@gnu.org> <871sz8894m.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1477165821 29353 195.159.176.226 (22 Oct 2016 19:50:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Oct 2016 19:50:21 +0000 (UTC) Cc: 24766@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 22 21:50:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1by2Iz-00063t-0Z for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Oct 2016 21:50:09 +0200 Original-Received: from localhost ([::1]:38523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1by2J1-0004gA-Cy for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Oct 2016 15:50:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1by2Iu-0004eo-VN for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 15:50:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1by2Ir-0004Sw-TU for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 15:50:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59453) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1by2Ir-0004Sq-Qe for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 15:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1by2Ir-0006i2-JS for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 15:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2016 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24766-submit@debbugs.gnu.org id=B24766.147716574225716 (code B ref 24766); Sat, 22 Oct 2016 19:50:01 +0000 Original-Received: (at 24766) by debbugs.gnu.org; 22 Oct 2016 19:49:02 +0000 Original-Received: from localhost ([127.0.0.1]:46619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1by2Ht-0006gh-Qn for submit@debbugs.gnu.org; Sat, 22 Oct 2016 15:49:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1by2Hs-0006gD-KW for 24766@debbugs.gnu.org; Sat, 22 Oct 2016 15:49:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1by2Hk-0003vX-8e for 24766@debbugs.gnu.org; Sat, 22 Oct 2016 15:48:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1by2Hk-0003vR-5T; Sat, 22 Oct 2016 15:48:52 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2096 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1by2Hh-0001gV-Hc; Sat, 22 Oct 2016 15:48:51 -0400 In-reply-to: <871sz8894m.fsf@gmail.com> (message from Alex on Sat, 22 Oct 2016 13:40:57 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124854 Archived-At: > From: Alex > Cc: 24766@debbugs.gnu.org > Date: Sat, 22 Oct 2016 13:40:57 -0600 > > >> The point does not move even when there are appropriate indentation > >> points to move to. > > > > It doesn't move because that's what UNINDENTED-OK means. > > I took UNINTENDED-OK to mean that "if non-nil, nothing is done in the > case that there are no appropriate indentation positions. If there are > appropriate indentation positions, then it should indent as usual." > > The docstring could be improved to state that. Definitely. Would you like to give it a try? > The optional argument is implicitly mentioned as "unless > this command is invoked with a numeric argument, in which case it > does nothing." Well, that's not how we document such functions, right? Both the effect of the argument, when used from Lisp, and the fact that it's the prefix argument in interactive invocation, should be stated. > > but other than fixing the documentation, I see > > no reason to change the behavior. Am I missing something? > > IIUC the current behaviour essentially makes indent-relative-maybe a > no-op. No, it's definitely not a no-op. It is only a no-op if the previous non-blank line has no white space at its beginning, or the current column is already past that first indentation point. IOW, indent-relative-maybe only ever indents to the first indentation point, and only when that indentation point is preceded by whitespace.