From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24880: 26.0.50; buff-menu: Command to unmark all buffers Date: Tue, 15 Nov 2016 18:03:35 +0200 Message-ID: <83h978hgrs.fsf@gnu.org> References: <871syqnsyo.fsf@gmail.com> <83a8dejkne.fsf@gnu.org> <87eg2ox0hi.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1479226296 19009 195.159.176.226 (15 Nov 2016 16:11:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Nov 2016 16:11:36 +0000 (UTC) Cc: 24880@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 15 17:11:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6gJh-000713-Mq for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 17:10:37 +0100 Original-Received: from localhost ([::1]:47318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6gJk-0005hj-VA for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 11:10:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6gDO-0001EI-Nx for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:04:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6gDK-0007V5-Qy for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:04:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6gDK-0007Ux-Nu for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c6gDK-0002S3-CS for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2016 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24880-submit@debbugs.gnu.org id=B24880.14792258299404 (code B ref 24880); Tue, 15 Nov 2016 16:04:02 +0000 Original-Received: (at 24880) by debbugs.gnu.org; 15 Nov 2016 16:03:49 +0000 Original-Received: from localhost ([127.0.0.1]:58368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6gD7-0002Rc-0Q for submit@debbugs.gnu.org; Tue, 15 Nov 2016 11:03:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6gD5-0002RM-Os for 24880@debbugs.gnu.org; Tue, 15 Nov 2016 11:03:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6gCx-0007Nc-I6 for 24880@debbugs.gnu.org; Tue, 15 Nov 2016 11:03:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6gCx-0007NV-Ej; Tue, 15 Nov 2016 11:03:39 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3161 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c6gCw-0007l6-Pn; Tue, 15 Nov 2016 11:03:39 -0500 In-reply-to: (message from Tino Calancha on Mon, 14 Nov 2016 19:29:14 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125716 Archived-At: > From: Tino Calancha > Date: Mon, 14 Nov 2016 19:29:14 +0900 (JST) > cc: Tino Calancha , Eli Zaretskii , > 24880@debbugs.gnu.org > > This is the amended patch: Thanks, please see a few comments below. > +@item M-@key{DEL} @var{markchar} Please remove the @var{markchar} part, we don't usually show user input after the keys. > +(defun bs-unmark-previous (count) > + "Unmark previous COUNT buffers. > +Move cursor vertically up COUNT lines." > + (interactive "p") The doc string should describe the effect of the prefix argument in interactive usage. Also, we prefer to say "move point", not "move cursor", since that's what the commands do; cursor movement is then performed by redisplay as the side effect. > + (define-key map "\M-\C-?" 'Buffer-menu-unmark-all-buffers) I'd prefer to use "\M-\177" instead, for consistency with DEL. (Yes, I know that other packages use \C-?, but we must start somewhere.) > + (bindings--define-key menu-map [umkab] > + '(menu-item "Unmark all buffers with mark" Buffer-menu-unmark-all-buffers Labels of menu items which invoke commands that prompt user for input should end in "...", as an indication that user input will be required. Also, "unmark ... with mark" sounds confusing, and is also quite long. How about "Remove marks..."? > + :help "Cancel a requested operation on buffers")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This should say "all buffers", right? > +(defun Buffer-menu-unmark-all-buffers (mark) > + "Cancel a requested operation on all buffers." > + (interactive "cRemove marks (RET means all):") This doc string should mention the argument MARK, and should also tell that the in interactive use the user is prompted for the character.