From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20619: Scrollbars Date: Sat, 24 Dec 2016 09:56:53 +0200 Message-ID: <83h95tzrne.fsf@gnu.org> References: <555CD05C.4070303@stsci.edu> <932ffe0b-8e9e-5a47-1a3f-47df43f7be42@univ-fcomte.fr> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1482566296 8439 195.159.176.226 (24 Dec 2016 07:58:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Dec 2016 07:58:16 +0000 (UTC) Cc: 20619@debbugs.gnu.org To: Eugen Dedu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 24 08:58:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKhDT-0001O0-5z for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Dec 2016 08:58:07 +0100 Original-Received: from localhost ([::1]:42609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKhDX-0006Cr-QI for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Dec 2016 02:58:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKhDR-0006CZ-15 for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 02:58:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKhDN-0004uw-WD for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 02:58:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37767) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKhDN-0004uq-TD for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 02:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKhDN-0002ey-Mj for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 02:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Dec 2016 07:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20619-submit@debbugs.gnu.org id=B20619.148256624410177 (code B ref 20619); Sat, 24 Dec 2016 07:58:01 +0000 Original-Received: (at 20619) by debbugs.gnu.org; 24 Dec 2016 07:57:24 +0000 Original-Received: from localhost ([127.0.0.1]:53166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKhCm-0002e5-4a for submit@debbugs.gnu.org; Sat, 24 Dec 2016 02:57:24 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKhCk-0002ds-37 for 20619@debbugs.gnu.org; Sat, 24 Dec 2016 02:57:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKhCb-0004iI-Rs for 20619@debbugs.gnu.org; Sat, 24 Dec 2016 02:57:16 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKhCb-0004iE-Ot; Sat, 24 Dec 2016 02:57:13 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3155 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cKhCa-0006d8-VS; Sat, 24 Dec 2016 02:57:13 -0500 In-reply-to: <932ffe0b-8e9e-5a47-1a3f-47df43f7be42@univ-fcomte.fr> (message from Eugen Dedu on Fri, 23 Dec 2016 21:30:17 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127383 Archived-At: > From: Eugen Dedu > Date: Fri, 23 Dec 2016 21:30:17 +0100 > > Now, to advance emacs support for HIDPI I would like to fix the > scrollbar. Do all people here agree that the scrollbar has a width > twice as normal? The reason is that in src/gtkutil.c there is this code: > > int > xg_get_default_scrollbar_width (void) > { > return scroll_bar_width_for_theme * xg_get_gdk_scale (); > } > > where xg_get_gdk_scale returns GDK_SCALE variable, i.e. 2 in general. > > If I replace with: > return scroll_bar_width_for_theme; > the scrollbar is shown correctly. > > This change was made by > https://github.com/emacs-mirror/emacs/commit/c0055ff5b03c9121ab5bf752496b09416f0f0a7d. > I think there was an error there, or perhaps in the mean time (since > May 2015) GTK has changed in a way so that scrollbars are taken into > account. What is your version of GTK? That commit points to a bug report (bug#20432), so this change is not a mistake, it did fix a real problem with scroll bars. We could make it conditional on the GTK version, though. The bug report mentions a specific GTK version. > Note that GDK_DPI_SCALE is only for font, AFAIU from > https://developer.gnome.org/gtk3/stable/gtk-x11.html. The code you mention doesn't use GDK_DPI_SCALE. > What do you think? Would you commit such a modification? I don't think we can simply revert the change in question, but maybe we could use different code based on GTK version. > I would like to look into other issues as well. Thank you! I see bugs 20432, 21469, and 18429 that might be relevant.