unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: 27597-done@debbugs.gnu.org
Subject: bug#27597: [PATCH] fix warnings in src/xdisp.c
Date: Sat, 08 Jul 2017 11:19:32 +0300	[thread overview]
Message-ID: <83h8ynl4rv.fsf@gnu.org> (raw)
In-Reply-To: <CANCZXo4MeqZ+MdxUUAK85md_7r_3KwEF_ZAsSXqS8cZ5m3+uNw@mail.gmail.com> (message from Alexander Kuleshov on Thu, 6 Jul 2017 17:47:03 +0600)

> From: Alexander Kuleshov <kuleshovmail@gmail.com>
> Date: Thu, 6 Jul 2017 17:47:03 +0600
> 
> here is simple fix for following warnings:
> 
> xdisp.c: In function ‘Fdump_glyph_matrix’:
> xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
> long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
> [-Werror=format=]
>    fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",
> 
> from src/xdisp.c

Thanks, pushed to master.

In the future, please provide a commit log message that is according
to our coding standards:

 . mention the names of functions in which you make changes
 . start sentences with a capital letter
 . mention the bug number

Here's the log message I used in this case:

	* src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
	Use pD directives for ptrdiff_t values instead of pI, to avoid
	compilation warnings on 64-bit hosts.  (Bug#27597)






  reply	other threads:[~2017-07-08  8:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06 11:47 bug#27597: [PATCH] fix warnings in src/xdisp.c Alexander Kuleshov
2017-07-08  8:19 ` Eli Zaretskii [this message]
2017-07-08 10:28   ` Alexander Kuleshov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h8ynl4rv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=27597-done@debbugs.gnu.org \
    --cc=kuleshovmail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).