From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: daniel.lopez999@gmail.com, 27772@debbugs.gnu.org
Subject: bug#27772: 25.2; Choosing tags files
Date: Mon, 07 Aug 2017 19:10:38 +0300 [thread overview]
Message-ID: <83h8xjtl35.fsf@gnu.org> (raw)
In-Reply-To: <87mv7c40bv.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)
> From: npostavs@users.sourceforge.net
> Date: Sun, 06 Aug 2017 21:45:56 -0400
> Cc: 27772@debbugs.gnu.org
>
> The problem is that the buffer gets changed by the time we reach there.
> The following patch seems to fix it (no need to explicitly use
> `buffer-local-variables' since normal variable access will check the
> buffer-local value first.
Seems reasonable, thanks.
> * lisp/progmodes/etags.el (visit-tags-table-buffer): Save the current
^^^^^^^
You meant "current buffer", I presume.
Do etags-tests.el still pass after this change? If so, would it be
possible to add a test for this bug?
Other than that, LGTM.
next prev parent reply other threads:[~2017-08-07 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 13:49 bug#27772: 25.2; Choosing tags files Daniel Lopez
2017-08-07 1:45 ` npostavs
2017-08-07 16:10 ` Eli Zaretskii [this message]
2017-08-08 2:55 ` npostavs
2017-08-08 14:21 ` Eli Zaretskii
2017-08-09 0:02 ` npostavs
2017-08-11 1:46 ` npostavs
[not found] ` <handler.27772.C.15024158873392.notifdonectrl.0@debbugs.gnu.org>
2017-08-11 3:46 ` bug#27772: acknowledged by developer (Re: bug#27772: 25.2; Choosing tags files) Daniel Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8xjtl35.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27772@debbugs.gnu.org \
--cc=daniel.lopez999@gmail.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).