From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom Date: Thu, 03 May 2018 05:32:44 +0300 Message-ID: <83h8nppiyb.fsf@gnu.org> References: <87r2mvo6c8.fsf@gmail.com> <5AE87AA3.6050602@gmx.at> <87o9hznfam.fsf@gmail.com> <5AE957BA.6000809@gmx.at> <87fu3ant8k.fsf@gmail.com> <0DFE6C67-38C5-45EE-B658-8BEF80B595FF@gnu.org> <5AE9C062.9010203@gmx.at> <87d0ydob8z.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1525314730 31139 195.159.176.226 (3 May 2018 02:32:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 May 2018 02:32:10 +0000 (UTC) Cc: 31312@debbugs.gnu.org, cyrus.and@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 03 04:32:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fE42P-0007z5-Ds for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 04:32:05 +0200 Original-Received: from localhost ([::1]:53519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fE44W-0001nc-3W for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 May 2018 22:34:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fE44N-0001mo-B0 for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 22:34:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fE44I-0007qm-Hn for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 22:34:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fE44I-0007qd-FC for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 22:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fE44I-0006Rk-6Z for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 22:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 May 2018 02:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 31312-submit@debbugs.gnu.org id=B31312.152531478524716 (code B ref 31312); Thu, 03 May 2018 02:34:02 +0000 Original-Received: (at 31312) by debbugs.gnu.org; 3 May 2018 02:33:05 +0000 Original-Received: from localhost ([127.0.0.1]:47559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fE43N-0006Qa-9D for submit@debbugs.gnu.org; Wed, 02 May 2018 22:33:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fE43K-0006Q3-UO for 31312@debbugs.gnu.org; Wed, 02 May 2018 22:33:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fE43E-0007On-Kd for 31312@debbugs.gnu.org; Wed, 02 May 2018 22:32:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fE438-0007MH-SD; Wed, 02 May 2018 22:32:50 -0400 Original-Received: from [176.228.60.248] (port=1514 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fE438-0006El-8o; Wed, 02 May 2018 22:32:50 -0400 In-reply-to: <87d0ydob8z.fsf@gmail.com> (message from Noam Postavsky on Wed, 02 May 2018 20:04:28 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145958 Archived-At: > From: Noam Postavsky > Cc: eliz@gnu.org, 31312@debbugs.gnu.org, cyrus.and@gmail.com > Date: Wed, 02 May 2018 20:04:28 -0400 > > martin rudalics writes: > > >> So we need the same defense after prepare_menu_bars as we > >> have after do_pending_changes, I think. > > > > If you mean something like > > > > if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw) > > sw = w; > > > > I'm afraid that this would fail since selected_window has no buffer > > any more (or may have even been recycled already). Or am I missing > > something? > > It seems to work (I don't know enough about the code to explain why). I > applied this patch: > > --- i/src/xdisp.c > +++ w/src/xdisp.c > @@ -13936,6 +13936,11 @@ redisplay_internal (void) > if (NILP (Vmemory_full)) > prepare_menu_bars (); > > + /* prepare_menu_bars may call lisp hooks and hence change the > + selected_window. */ > + if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw) > + sw = w; > + > reconsider_clip_changes (w); > > /* In most cases selected window displays current buffer. */ > > And then following the original recipe does not segfault. There is a > Lisp error, but I think that's already a bug in zoom and/or doom. Right. Please push to the emacs-26 branch, and thanks.