From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 32304@debbugs.gnu.org
Subject: bug#32304: 27.0.50; tramp-tests issue with double slash
Date: Sun, 29 Jul 2018 20:26:19 +0300 [thread overview]
Message-ID: <83h8kiq7gk.fsf@gnu.org> (raw)
In-Reply-To: <87pnz6dn2b.fsf@gmx.de> (message from Michael Albinus on Sun, 29 Jul 2018 18:27:40 +0200)
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Sun, 29 Jul 2018 18:27:40 +0200
> Cc: 32304@debbugs.gnu.org
>
> > "//" has a special meaning at the beginning of a file name on Cygwin and
> > MS-Windows; see the comment near the beginning of
> > search_embedded_absfilename. So I don't think there's a real bug here.
> > Maybe the expected result of the test should simply be adjusted, as in
> > the attached patch. Someone who builds on MS-Windows would have to
> > check this.
>
> Thanks for the report. However, your patch seems just to hide the
> problem in tramp-tests.el. Wouldn't it be better to fix this?
>
> What about the appended patch?
Doesn't seem to help here, in the native MS-Windows build; log
attached.
Can you tell how binding system-type was supposed to solve this?
[-- Attachment #2: tramp-tests.log --]
[-- Type: application/octet-stream, Size: 10667 bytes --]
Running 63 tests (2018-07-29 20:24:27+0300, selector `(not (tag :unstable))')
failed 1/63 tramp-test00-availability (0.000000 sec)
passed 2/63 tramp-test01-file-name-syntax (0.000000 sec)
passed 3/63 tramp-test01-file-name-syntax-separate (0.281250 sec)
passed 4/63 tramp-test01-file-name-syntax-simplified (0.000000 sec)
passed 5/63 tramp-test02-file-name-dissect (0.187500 sec)
passed 6/63 tramp-test02-file-name-dissect-separate (0.281250 sec)
passed 7/63 tramp-test02-file-name-dissect-simplified (0.062500 sec)
passed 8/63 tramp-test03-file-name-defaults (0.281250 sec)
skipped 9/63 tramp-test03-file-name-host-rules (0.000000 sec)
skipped 10/63 tramp-test03-file-name-method-rules (0.000000 sec)
Test tramp-test04-substitute-in-file-name backtrace:
signal(ert-test-failed (((should (string-equal (substitute-in-file-n
ert-fail(((should (string-equal (substitute-in-file-name "/method:ho
(if (unwind-protect (setq value-2885 (apply fn-2883 args-2884)) (set
(let (form-description-2887) (if (unwind-protect (setq value-2885 (a
(let ((value-2885 'ert-form-evaluation-aborted-2886)) (let (form-des
(let* ((fn-2883 #'string-equal) (args-2884 (condition-case err (let
(closure (t) nil (let* ((fn-2878 #'string-equal) (args-2879 (conditi
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name tramp-test04-substitute-in-file-name
ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))))
command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/net/tramp-tests.el"
command-line()
normal-top-level()
Test tramp-test04-substitute-in-file-name condition:
(ert-test-failed
((should
(string-equal
(substitute-in-file-name "/method:host://foo")
"/method:host:/foo"))
:form
(string-equal "/method:host://foo" "/method:host:/foo")
:value nil))
FAILED 11/63 tramp-test04-substitute-in-file-name (0.000000 sec)
passed 12/63 tramp-test05-expand-file-name (0.000000 sec)
skipped 13/63 tramp-test05-expand-file-name-relative (0.000000 sec)
passed 14/63 tramp-test06-directory-file-name (0.000000 sec)
skipped 15/63 tramp-test07-file-exists-p (0.000000 sec)
skipped 16/63 tramp-test08-file-local-copy (0.000000 sec)
skipped 17/63 tramp-test09-insert-file-contents (0.000000 sec)
skipped 18/63 tramp-test10-write-region (0.000000 sec)
skipped 19/63 tramp-test11-copy-file (0.015625 sec)
skipped 20/63 tramp-test12-rename-file (0.000000 sec)
skipped 21/63 tramp-test13-make-directory (0.000000 sec)
skipped 22/63 tramp-test14-delete-directory (0.000000 sec)
skipped 23/63 tramp-test15-copy-directory (0.000000 sec)
skipped 24/63 tramp-test16-directory-files (0.140625 sec)
skipped 25/63 tramp-test16-file-expand-wildcards (0.000000 sec)
skipped 26/63 tramp-test17-dired-with-wildcards (0.000000 sec)
skipped 27/63 tramp-test17-insert-directory (0.000000 sec)
skipped 28/63 tramp-test18-file-attributes (0.000000 sec)
skipped 29/63 tramp-test19-directory-files-and-attributes (0.000000 sec)
skipped 30/63 tramp-test20-file-modes (0.000000 sec)
skipped 31/63 tramp-test21-file-links (0.000000 sec)
skipped 32/63 tramp-test22-file-times (0.000000 sec)
skipped 33/63 tramp-test23-visited-file-modtime (0.000000 sec)
skipped 34/63 tramp-test24-file-acl (0.000000 sec)
skipped 35/63 tramp-test25-file-selinux (0.000000 sec)
skipped 36/63 tramp-test26-file-name-completion (0.000000 sec)
skipped 37/63 tramp-test27-load (0.000000 sec)
skipped 38/63 tramp-test28-process-file (0.000000 sec)
skipped 39/63 tramp-test29-start-file-process (0.000000 sec)
skipped 40/63 tramp-test30-interrupt-process (0.000000 sec)
skipped 41/63 tramp-test31-shell-command (0.000000 sec)
skipped 42/63 tramp-test32-environment-variables (0.000000 sec)
skipped 43/63 tramp-test32-environment-variables-and-port-numbers (0.000000 sec)
skipped 44/63 tramp-test33-explicit-shell-file-name (0.000000 sec)
skipped 45/63 tramp-test34-exec-path (0.000000 sec)
skipped 46/63 tramp-test35-vc-registered (0.000000 sec)
skipped 47/63 tramp-test36-make-auto-save-file-name (0.000000 sec)
skipped 48/63 tramp-test37-find-backup-file-name (0.000000 sec)
skipped 49/63 tramp-test38-make-nearby-temp-file (0.000000 sec)
skipped 50/63 tramp-test39-special-characters (0.000000 sec)
skipped 51/63 tramp-test39-special-characters-with-ls (0.000000 sec)
skipped 52/63 tramp-test39-special-characters-with-perl (0.000000 sec)
skipped 53/63 tramp-test39-special-characters-with-stat (0.000000 sec)
skipped 54/63 tramp-test40-utf8 (0.000000 sec)
skipped 55/63 tramp-test40-utf8-with-ls (0.000000 sec)
skipped 56/63 tramp-test40-utf8-with-perl (0.000000 sec)
skipped 57/63 tramp-test40-utf8-with-stat (0.000000 sec)
skipped 58/63 tramp-test41-file-system-info (0.000000 sec)
Test tramp-test43-auto-load backtrace:
signal(ert-test-failed (((should (string-match "Tramp loaded: t[\n\r]
ert-fail(((should (string-match "Tramp loaded: t[\n\r]+" (shell-comma
(if (unwind-protect (setq value-5650 (apply fn-5648 args-5649)) (set
(let (form-description-5652) (if (unwind-protect (setq value-5650 (a
(let ((value-5650 'ert-form-evaluation-aborted-5651)) (let (form-des
(let* ((fn-5648 #'string-match) (args-5649 (condition-case err (let
(let ((default-directory (expand-file-name temporary-file-directory)
(closure (t) nil (let ((default-directory (expand-file-name temporar
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name tramp-test43-auto-load :documentation
ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))))
command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/net/tramp-tests.el"
command-line()
normal-top-level()
Test tramp-test43-auto-load condition:
(ert-test-failed
((should
(string-match "Tramp loaded: t[
\r]+"
(shell-command-to-string ...)))
:form
(string-match "Tramp loaded: t[
\r]+" "Tramp loaded: nil
")
:value nil))
FAILED 59/63 tramp-test43-auto-load (0.203125 sec)
passed 60/63 tramp-test43-delay-load (1.875000 sec)
skipped 61/63 tramp-test43-recursive-load (0.000000 sec)
passed 62/63 tramp-test43-remote-load-path (1.765625 sec)
Test tramp-test44-unload backtrace:
signal(ert-test-failed ("`tramp-register-archive-file-name-handler'
ert-fail("`tramp-register-archive-file-name-handler' still bound")
(and (or (and (boundp x) (null (local-variable-if-set-p x))) (and (f
(closure (t) (x) (and (or (and (boundp x) (null (local-variable-if-s
mapatoms((closure (t) (x) (and (or (and (boundp x) (null (local-vari
(progn (unload-feature 'tramp 'force) (let* ((fn-5690 #'featurep) (a
(if (featurep 'tramp) (progn (unload-feature 'tramp 'force) (let* ((
(closure (t) nil (let ((value-5683 (gensym "ert-form-evaluation-abor
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name tramp-test44-unload :documentation "C
ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))))
command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/net/tramp-tests.el"
command-line()
normal-top-level()
Test tramp-test44-unload condition:
(ert-test-failed "`tramp-register-archive-file-name-handler' still bound")
FAILED 63/63 tramp-test44-unload (0.375000 sec)
Ran 63 tests, 12 results as expected, 3 unexpected, 48 skipped (2018-07-29 20:24:37+0300, 9.953125 sec)
1 expected failures
3 unexpected results:
FAILED tramp-test04-substitute-in-file-name
FAILED tramp-test43-auto-load
FAILED tramp-test44-unload
48 skipped results:
SKIPPED tramp-test03-file-name-host-rules
SKIPPED tramp-test03-file-name-method-rules
SKIPPED tramp-test05-expand-file-name-relative
SKIPPED tramp-test07-file-exists-p
SKIPPED tramp-test08-file-local-copy
SKIPPED tramp-test09-insert-file-contents
SKIPPED tramp-test10-write-region
SKIPPED tramp-test11-copy-file
SKIPPED tramp-test12-rename-file
SKIPPED tramp-test13-make-directory
SKIPPED tramp-test14-delete-directory
SKIPPED tramp-test15-copy-directory
SKIPPED tramp-test16-directory-files
SKIPPED tramp-test16-file-expand-wildcards
SKIPPED tramp-test17-dired-with-wildcards
SKIPPED tramp-test17-insert-directory
SKIPPED tramp-test18-file-attributes
SKIPPED tramp-test19-directory-files-and-attributes
SKIPPED tramp-test20-file-modes
SKIPPED tramp-test21-file-links
SKIPPED tramp-test22-file-times
SKIPPED tramp-test23-visited-file-modtime
SKIPPED tramp-test24-file-acl
SKIPPED tramp-test25-file-selinux
SKIPPED tramp-test26-file-name-completion
SKIPPED tramp-test27-load
SKIPPED tramp-test28-process-file
SKIPPED tramp-test29-start-file-process
SKIPPED tramp-test30-interrupt-process
SKIPPED tramp-test31-shell-command
SKIPPED tramp-test32-environment-variables
SKIPPED tramp-test32-environment-variables-and-port-numbers
SKIPPED tramp-test33-explicit-shell-file-name
SKIPPED tramp-test34-exec-path
SKIPPED tramp-test35-vc-registered
SKIPPED tramp-test36-make-auto-save-file-name
SKIPPED tramp-test37-find-backup-file-name
SKIPPED tramp-test38-make-nearby-temp-file
SKIPPED tramp-test39-special-characters
SKIPPED tramp-test39-special-characters-with-ls
SKIPPED tramp-test39-special-characters-with-perl
SKIPPED tramp-test39-special-characters-with-stat
SKIPPED tramp-test40-utf8
SKIPPED tramp-test40-utf8-with-ls
SKIPPED tramp-test40-utf8-with-perl
SKIPPED tramp-test40-utf8-with-stat
SKIPPED tramp-test41-file-system-info
SKIPPED tramp-test43-recursive-load
next prev parent reply other threads:[~2018-07-29 17:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 15:54 bug#32304: 27.0.50; tramp-tests issue with double slash Ken Brown
2018-07-29 16:27 ` Michael Albinus
2018-07-29 16:47 ` Ken Brown
2018-07-29 16:55 ` Michael Albinus
2018-07-29 17:00 ` Ken Brown
2018-07-30 10:43 ` Michael Albinus
2018-07-30 12:17 ` Ken Brown
2018-07-30 14:45 ` Eli Zaretskii
2018-07-30 20:50 ` Michael Albinus
2018-07-31 2:34 ` Eli Zaretskii
2018-07-31 5:00 ` Michael Albinus
2018-08-08 13:48 ` Michael Albinus
2018-08-08 14:35 ` Eli Zaretskii
2018-08-08 14:42 ` Eli Zaretskii
2018-08-08 18:06 ` Michael Albinus
2018-08-09 12:24 ` Michael Albinus
2018-08-09 15:18 ` Eli Zaretskii
2018-08-10 7:27 ` Michael Albinus
2018-08-08 15:26 ` Michael Albinus
2018-08-08 15:57 ` Eli Zaretskii
2018-07-31 4:58 ` Michael Albinus
2018-07-29 17:26 ` Eli Zaretskii [this message]
2018-07-30 8:26 ` Michael Albinus
2018-07-31 14:46 ` Andy Moreton
2018-07-31 20:57 ` Michael Albinus
2018-07-31 22:07 ` Ken Brown
2018-08-01 20:51 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8kiq7gk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32304@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).