From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 32319-done@debbugs.gnu.org
Subject: bug#32319: 27.0.50; flyspell-mode error on start
Date: Sat, 11 Aug 2018 10:36:14 +0300 [thread overview]
Message-ID: <83h8k1mk29.fsf@gnu.org> (raw)
In-Reply-To: <87tvo9pevo.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Sat, 04 Aug 2018 22:21:47 -0700)
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: 32319@debbugs.gnu.org
> Date: Sat, 04 Aug 2018 22:21:47 -0700
>
> > Does the patch below produce a useful diagnostic?
>
> This patch is just fine, and would certainly be a lot better than the
> current situation. I only note that, if we allow this function to fail
> silently, the error you get *later on*, when you try to use flyspell to
> do something, comes directly from hunspell and says exactly what the
> problem is (ie, which dictionary it tried and failed to load). That's
> even more helpful. If we did that, this function could just call
> `ispell-print-if-debug' and log the failure quietly.
>
> But raising an error directly is also fine, and might be preferable in
> order to avoid creating weird problems further down the line.
OK, so I installed my patch on the master branch, and I'm marking this
bug done. Thanks for the analysis and the feedback.
prev parent reply other threads:[~2018-08-11 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 19:42 bug#32319: 27.0.50; flyspell-mode error on start Eric Abrahamsen
2018-07-31 15:33 ` Eli Zaretskii
2018-08-01 2:03 ` Eric Abrahamsen
2018-08-01 6:00 ` Eli Zaretskii
2018-08-01 19:51 ` Eric Abrahamsen
2018-08-04 11:02 ` Eli Zaretskii
2018-08-05 5:21 ` Eric Abrahamsen
2018-08-11 7:36 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8k1mk29.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32319-done@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).