From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms Date: Tue, 25 Jun 2019 20:26:40 +0300 Message-ID: <83h88dlgof.fsf@gnu.org> References: <83d1htdwgo.fsf@gnu.org> <838tsgd912.fsf@gnu.org> <83k1d9linv.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="254331"; mail-complaints-to="usenet@blaine.gmane.org" Cc: david.hull@openx.com, 24960@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 19:27:30 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfpE6-0013xi-LJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 19:27:26 +0200 Original-Received: from localhost ([::1]:34230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfpE5-0007Kp-OA for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 13:27:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33210) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfpDn-0007J5-Bn for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:27:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfpDl-0006Sp-I4 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:27:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfpDi-0006P6-7E for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfpDh-0007kc-V0 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 24960-submit@debbugs.gnu.org id=B24960.156148361129774 (code B ref 24960); Tue, 25 Jun 2019 17:27:01 +0000 Original-Received: (at 24960) by debbugs.gnu.org; 25 Jun 2019 17:26:51 +0000 Original-Received: from localhost ([127.0.0.1]:33442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpDX-0007k9-4D for submit@debbugs.gnu.org; Tue, 25 Jun 2019 13:26:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpDU-0007jw-Oi for 24960@debbugs.gnu.org; Tue, 25 Jun 2019 13:26:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hfpDO-00067O-6H; Tue, 25 Jun 2019 13:26:42 -0400 Original-Received: from [176.228.60.248] (port=2829 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hfpDM-0007Ed-Ib; Tue, 25 Jun 2019 13:26:41 -0400 In-reply-to: (message from Lars Ingebrigtsen on Tue, 25 Jun 2019 19:13:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161404 Archived-At: > From: Lars Ingebrigtsen > Cc: david.hull@openx.com, 24960@debbugs.gnu.org > Date: Tue, 25 Jun 2019 19:13:55 +0200 > > if (len > 0) > - make_tag (cp, len, true, s, cp + len - s, lineno, linecharno); > + /* If the name is quoted, the quotes are not part of the name. */ > + if (len > 2 && cp[0] == '\'' && cp[len - 1] == '\'') > + { > + cp++; > + len -= 2; > + } > + make_tag (cp, len, true, s, pos, lineno, linecharno); > > I think what was meant was that the make_tag should be in that "if" > branch, so I slapped a brace pair around the new lines. Yes, thanks.