From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 17 Oct 2019 09:43:14 +0300 Message-ID: <83h847dg8t.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <83y2xkcyu9.fsf@gnu.org> <87o8yg5v80.fsf@mail.linkov.net> <83o8ygcvb0.fsf@gnu.org> <87mue01lu5.fsf@mail.linkov.net> <20191016203740.4mgqbrqee5yrq6nm@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="16036"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andreyorst@gmail.com, 37774@debbugs.gnu.org, juri@linkov.net To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 17 08:44:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKzW7-00042P-OC for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 08:44:11 +0200 Original-Received: from localhost ([::1]:37482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKzW6-0006jg-HO for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 02:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57446) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKzVy-0006gT-Tw for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:44:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKzVx-0002CF-UJ for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKzVx-0002CA-RM for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKzVx-0000Vo-N8 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2019 06:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712946221932 (code B ref 37774); Thu, 17 Oct 2019 06:44:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 17 Oct 2019 06:43:42 +0000 Original-Received: from localhost ([127.0.0.1]:47023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKzVd-0000V2-Tp for submit@debbugs.gnu.org; Thu, 17 Oct 2019 02:43:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKzVb-0000Ui-QU for 37774@debbugs.gnu.org; Thu, 17 Oct 2019 02:43:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKzVT-0001x5-Ot; Thu, 17 Oct 2019 02:43:32 -0400 Original-Received: from [176.228.60.248] (port=4068 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKzVS-0005Dv-Mt; Thu, 17 Oct 2019 02:43:31 -0400 In-reply-to: <20191016203740.4mgqbrqee5yrq6nm@Ergus> (message from Ergus on Wed, 16 Oct 2019 22:37:40 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169530 Archived-At: > Date: Wed, 16 Oct 2019 22:37:40 +0200 > From: Ergus > Cc: Eli Zaretskii , andreyorst@gmail.com, > 37774@debbugs.gnu.org > > >>> (custom-set-faces > >>> '(region ((((class color) (background light)) (:background "gray90")))) > >> > >> So maybe we should modify custom-set-faces to preserve the :extend > >> attribute? Would that solve the problem? > > > >I don't know how feasible this is. This looks like a hack. > > > Actually it will be a transition workaround than could be removed in > emacs 28 for those who don't want (or know) how to update manually > because they made it with the interface. > > But will break the case when the user explicitly wants a non extensible > region face and set that in the custom-set-face section in his init. If we implement this only when the custom-set-face does NOT include an explicit :extend setting, then there will be no breakage, I think.