unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 37829@debbugs.gnu.org, all_but_last@163.com
Subject: bug#37829: 27.0.50; Overlay behaviour changed without documentation.
Date: Sun, 20 Oct 2019 14:35:55 +0300	[thread overview]
Message-ID: <83h843644k.fsf@gnu.org> (raw)
In-Reply-To: <87tv83fz0n.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun,  20 Oct 2019 13:16:08 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Zhu Zihao <all_but_last@163.com>,  37829@debbugs.gnu.org
> Date: Sun, 20 Oct 2019 13:16:08 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Crystal ball says it's because the mode-line face doesn't have the
> > :extend attribute by default.  If so, this change _is_ in NEWS and in
> > the ELisp manual.
> 
> Hasn't there been sufficient fallout now from this change that we should
> consider doing the :extend stuff the opposite way?

No, I don't think so.  All the complaints until now were about Diff
mode and related modes, and we made the relevant faces extend a few
hours ago.  At least in one case, this change allowed to _remove_ some
kludgey code (in info.el).

And doing this the opposite way makes no sense to me, it's in effect
the same as removing the feature.

> This change breaks a lot of out-of-tree code.

No, it doesn't break any code.  It changes how display looks in some
cases, so people are surprised at first.

For this particular bug report, why would someone expect the overlay's
color to extend to the end of the line instead of affecting only the
text that the overlay covers?





  reply	other threads:[~2019-10-20 11:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20  8:49 bug#37829: 27.0.50; Overlay behaviour changed without documentation Zhu Zihao
2019-10-20 11:05 ` Eli Zaretskii
2019-10-20 11:16   ` Lars Ingebrigtsen
2019-10-20 11:35     ` Eli Zaretskii [this message]
2019-10-20 11:43       ` Lars Ingebrigtsen
2019-10-20 12:01         ` Eli Zaretskii
2019-10-20 16:49           ` Lars Ingebrigtsen
2019-10-20 19:13             ` Eli Zaretskii
2019-10-21 19:43               ` Lars Ingebrigtsen
2019-10-20 11:31   ` Zhu Zihao
2019-10-20 16:14   ` Zhu Zihao
2019-10-20 19:15     ` Eli Zaretskii
2020-08-21 15:03   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h843644k.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37829@debbugs.gnu.org \
    --cc=all_but_last@163.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).