From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11339: 24.1.50; read-{buffer,file-name}-completion-ignore-case fails on non-ascii Date: Thu, 07 Nov 2019 20:12:31 +0200 Message-ID: <83h83feesw.fsf@gnu.org> References: <87ehrbyg8t.fsf@escher.home> <87lfszxtcl.fsf@marxist.se> <83bltvl55x.fsf@gnu.org> <87o8xvz0hp.fsf@gmx.net> <83tv7mkb0l.fsf@gnu.org> <87d0ea9uxg.fsf@gmx.net> <83eeyphr5q.fsf@gnu.org> <87lfsvyd4i.fsf@gmx.net> <87h83jy5kp.fsf@gmx.net> <83v9rzh8gs.fsf@gnu.org> <875zjzy0yg.fsf@gmx.net> <831rulgcw3.fsf@gnu.org> <87wocb21so.fsf@gmx.net> <83tv7fekkf.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153606"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 11339@debbugs.gnu.org, stephen.berman@gmx.net, stefan@marxist.se To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 07 19:13:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSmHd-000dpf-B1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Nov 2019 19:13:25 +0100 Original-Received: from localhost ([::1]:46894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSmHb-0005a6-EQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Nov 2019 13:13:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59876) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSmHI-0005ZW-DB for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 13:13:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSmHH-0005a0-E9 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 13:13:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35061) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSmHH-0005Zp-AR for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 13:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSmHH-0004m8-1G for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 13:13:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Nov 2019 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11339 X-GNU-PR-Package: emacs Original-Received: via spool by 11339-submit@debbugs.gnu.org id=B11339.157315037718344 (code B ref 11339); Thu, 07 Nov 2019 18:13:02 +0000 Original-Received: (at 11339) by debbugs.gnu.org; 7 Nov 2019 18:12:57 +0000 Original-Received: from localhost ([127.0.0.1]:43882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmHA-0004lo-LS for submit@debbugs.gnu.org; Thu, 07 Nov 2019 13:12:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmH8-0004lb-Id for 11339@debbugs.gnu.org; Thu, 07 Nov 2019 13:12:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iSmH2-0005Rr-QT; Thu, 07 Nov 2019 13:12:48 -0500 Original-Received: from [176.228.60.248] (port=3597 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iSmGz-00055z-TG; Thu, 07 Nov 2019 13:12:47 -0500 In-reply-to: (message from Stefan Monnier on Thu, 07 Nov 2019 11:27:50 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171105 Archived-At: > From: Stefan Monnier > Cc: stephen.berman@gmx.net, 11339@debbugs.gnu.org, stefan@marxist.se > Date: Thu, 07 Nov 2019 11:27:50 -0500 > > >> I think the core of the bug is reproduced below: > >> > >> M-: (let ((completion-ignore-case t)) (try-completion "bah" '("bah" "bAh"))) > >> > >> this returns t instead of returning "bah". > >> Probably an error in the handling of `matchcount` in `try-completion`. > > > > Are you sure? > > I think so, yes. The patch below fixes Stefan's simplified test case, but the original problem is still unsolved: "C-x b ba TAB TAB" says "Sole completion". What did I miss? diff --git a/src/minibuf.c b/src/minibuf.c index f6cf47f..2670211 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -1363,7 +1363,13 @@ DEFUN ("try-completion", Ftry_completion, Stry_completion, 2, 3, 0, bestmatch = eltstring; } if (bestmatchsize != SCHARS (eltstring) - || bestmatchsize != matchsize) + || bestmatchsize != matchsize + || (completion_ignore_case + && !EQ (Fcompare_strings (bestmatch, zero, + make_fixnum (compare), + eltstring, zero, + make_fixnum (compare), Qnil), + Qt))) /* Don't count the same string multiple times. */ matchcount += matchcount <= 1; bestmatchsize = matchsize;