From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11339: 24.1.50; read-{buffer,file-name}-completion-ignore-case fails on non-ascii Date: Sat, 09 Nov 2019 21:57:36 +0200 Message-ID: <83h83c961b.fsf@gnu.org> References: <87ehrbyg8t.fsf@escher.home> <87lfszxtcl.fsf@marxist.se> <83bltvl55x.fsf@gnu.org> <87o8xvz0hp.fsf@gmx.net> <83tv7mkb0l.fsf@gnu.org> <87d0ea9uxg.fsf@gmx.net> <83eeyphr5q.fsf@gnu.org> <87lfsvyd4i.fsf@gmx.net> <87h83jy5kp.fsf@gmx.net> <83v9rzh8gs.fsf@gnu.org> <875zjzy0yg.fsf@gmx.net> <831rulgcw3.fsf@gnu.org> <87wocb21so.fsf@gmx.net> <83tv7fekkf.fsf@gnu.org> <83h83feesw.fsf@gnu.org> <83eeyh9zjn.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="263191"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 11339-done@debbugs.gnu.org, stephen.berman@gmx.net, stefan@marxist.se To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 09 20:58:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iTWsE-0016J6-C4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Nov 2019 20:58:18 +0100 Original-Received: from localhost ([::1]:39596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTWsD-0002ec-7v for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Nov 2019 14:58:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46181) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTWrz-0002eR-O1 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 14:58:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTWry-0000sv-Ot for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 14:58:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41483) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTWry-0000rV-Kw for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 14:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTWry-0004Me-I2 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 14:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2019 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11339 X-GNU-PR-Package: emacs Original-Received: via spool by 11339-done@debbugs.gnu.org id=D11339.157332947416762 (code D ref 11339); Sat, 09 Nov 2019 19:58:02 +0000 Original-Received: (at 11339-done) by debbugs.gnu.org; 9 Nov 2019 19:57:54 +0000 Original-Received: from localhost ([127.0.0.1]:50304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTWrq-0004MI-CP for submit@debbugs.gnu.org; Sat, 09 Nov 2019 14:57:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTWrm-0004M4-OK for 11339-done@debbugs.gnu.org; Sat, 09 Nov 2019 14:57:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iTWrg-0008Kl-Sr; Sat, 09 Nov 2019 14:57:44 -0500 Original-Received: from [176.228.60.248] (port=3635 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iTWrf-0001zw-Qz; Sat, 09 Nov 2019 14:57:44 -0500 In-reply-to: (message from Stefan Monnier on Sat, 09 Nov 2019 13:24:06 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171349 Archived-At: > From: Stefan Monnier > Cc: stephen.berman@gmx.net, 11339@debbugs.gnu.org, stefan@marxist.se > Date: Sat, 09 Nov 2019 13:24:06 -0500 > > > What about the below? It passes all the tests, and also fixes the > > original use case. > > Sounds good. Thanks, installed. > I have the impression that I was the original author of that "early > exit" optimization (or at least some of it), but my brain must be > decaying because I have a hard time understanding the code. I also > wonder if it's really worth the effort (of the optimization, I > mean). AFAICT, you were the author of the "don't count the same string more than once" fragment. I'm closing the bug report.