unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 38218@debbugs.gnu.org
Subject: bug#38218: network-interface-list only returns IPv4 addresses
Date: Tue, 26 Nov 2019 19:17:49 +0200	[thread overview]
Message-ID: <83h82qsgjm.fsf@gnu.org> (raw)
In-Reply-To: <m2eexv58ym.fsf@gmail.com> (message from Robert Pluim on Tue, 26 Nov 2019 09:37:53 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Date: Tue, 26 Nov 2019 09:37:53 +0100
> Cc: 38218@debbugs.gnu.org
> 
>     Robert> Iʼll just push and wait for the screams then. (Eli, thatʼs a joke).
> 
> Iʼve now pushed it.

It needed a bit of tweaking for mingw.org's MinGW, so that it would
work on XP.  However, after making the changes, one test from
nsm-tests.el fails here:

  127.1/0 No such host is known.
  127.1/0 No such host is known.
  Test nsm-check-local-subnet-ipv4 backtrace:
    signal(ert-test-failed (((should (eq nil (nsm-should-check "127.1")
    ert-fail(((should (eq nil (nsm-should-check "127.1"))) :form (eq ni
    (if (unwind-protect (setq value-44 (apply fn-42 args-43)) (setq for
    (let (form-description-46) (if (unwind-protect (setq value-44 (appl
    (let ((value-44 'ert-form-evaluation-aborted-45)) (let (form-descri
    (let* ((fn-42 #'eq) (args-43 (condition-case err (let ((signal-hook
    (let ((nsm-trust-local-network t)) (let* ((fn-37 #'eq) (args-38 (co
    (let ((local-ip '[172 26 128 160 0]) (mask '[255 255 255 0 0]) (wro
    (closure (t) nil (let ((local-ip '[172 26 128 160 0]) (mask '[255 2
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-tes
    ert-run-test(#s(ert-test :name nsm-check-local-subnet-ipv4 :documen
    ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
    ert-run-tests((not (tag :unstable)) #f(compiled-function (event-typ
    ert-run-tests-batch((not (tag :unstable)))
    ert-run-tests-batch-and-exit((not (tag :unstable)))
    eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
    command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp8
    command-line()
    normal-top-level()
  Test nsm-check-local-subnet-ipv4 condition:
      (ert-test-failed
       ((should
	 (eq nil
	     (nsm-should-check "127.1")))
	:form
	(eq nil t)
	:value nil))
     FAILED  1/2  nsm-check-local-subnet-ipv4 (4.656250 sec)

Does it work for you in your MinGW build?  If so, could you eyeball
the code I added/modified in w32.c to see if I goofed somewhere?

Thanks.





  reply	other threads:[~2019-11-26 17:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 10:13 bug#38218: network-interface-list only returns IPv4 addresses Robert Pluim
2019-11-15 10:18 ` Robert Pluim
2019-11-16  5:17   ` Lars Ingebrigtsen
2019-11-17 20:50     ` Robert Pluim
2019-11-26  8:37       ` Robert Pluim
2019-11-26 17:17         ` Eli Zaretskii [this message]
2019-11-26 18:10           ` Robert Pluim
2019-11-26 18:23             ` Eli Zaretskii
2019-11-26 18:29               ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h82qsgjm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38218@debbugs.gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).