unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 38812-done@debbugs.gnu.org
Subject: bug#38812: 28.0.50; Custom: Problem with reverting some session's customizations
Date: Wed, 01 Jan 2020 19:51:39 +0200	[thread overview]
Message-ID: <83h81fjc9g.fsf@gnu.org> (raw)
In-Reply-To: <CABczVwfF4Fmnc=bgWeZ4JhyHEDrTXixCQSVPyNtn4GQ13GE1fA@mail.gmail.com> (message from Mauro Aranda on Tue, 31 Dec 2019 14:38:02 -0300)

> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Tue, 31 Dec 2019 14:38:02 -0300
> Cc: 38812@debbugs.gnu.org
> 
> > My alternative patch is below.  WDYT?
> >
> > diff --git a/lisp/custom.el b/lisp/custom.el
> > index 26bdaae2c2..7ed85b22e8 100644
> > --- a/lisp/custom.el
> > +++ b/lisp/custom.el
> > @@ -886,7 +886,10 @@ custom-push-theme
> >   (put theme 'theme-settings
> >       (cons (list prop symbol theme value)
> >     (delq res theme-settings)))
> > - (setcar (cdr setting) value)))
> > +        ;; It's tempting to use setcar here, but that could
> > +        ;; inadvertently modify other properties in SYMBOL's proplist,
> > +        ;; if those just happen to share elements with the value of PROP.
> > +        (put symbol prop (cons (list theme value) (delq setting old)))))
> >       ;; Add a new setting:
> >       (t
> >        (when (custom--should-apply-setting theme)
> 
> Looks good, thank you.

Thanks, pushed.





      reply	other threads:[~2020-01-01 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30 14:11 bug#38812: 28.0.50; Custom: Problem with reverting some session's customizations Mauro Aranda
2019-12-31 14:22 ` Mauro Aranda
2019-12-31 16:04   ` Eli Zaretskii
2019-12-31 17:21     ` Mauro Aranda
2019-12-31 17:25       ` Eli Zaretskii
2019-12-31 17:38         ` Mauro Aranda
2020-01-01 17:51           ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h81fjc9g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38812-done@debbugs.gnu.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).