From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37189: 25.4.1: vc-hg-ignore implementation is missing Date: Tue, 04 Feb 2020 20:55:03 +0200 Message-ID: <83h806gp2w.fsf@gnu.org> References: <1ba53ae2-42a4-3ab3-d4f2-2ceae565d198@gmx.de> <52917e6f-2f00-25cf-4353-dfb40287d0ea@gmx.de> <83pnkrdpb3.fsf@gnu.org> <679942e8-abe9-b0fc-720d-75a54d8d0b5a@gmx.de> <95da41e8-7a55-a15c-cfa7-d70366f9ee6b@gmx.de> <412195c1-e196-12af-933b-0312f5075847@yandex.ru> <57825d73-27a4-d5f5-8198-a172796a558a@gmx.de> <1ebc6077-9175-65ba-4996-282bb2c8eca5@yandex.ru> <6145d6f6-37a8-7166-731b-57669086b145@gmx.de> <838slmk90j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="81170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 37189@debbugs.gnu.org, dgutov@yandex.ru To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 04 19:56:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iz3Mx-000Kve-Tq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Feb 2020 19:56:19 +0100 Original-Received: from localhost ([::1]:36438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz3Mx-0008Eb-01 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Feb 2020 13:56:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59490) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz3Mo-0008CL-Ce for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 13:56:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz3Mj-0004Y1-Ea for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 13:56:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz3Mg-0004UP-Mp for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 13:56:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iz3Mg-0007Ns-It for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 13:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Feb 2020 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37189 X-GNU-PR-Package: emacs Original-Received: via spool by 37189-submit@debbugs.gnu.org id=B37189.158084252028330 (code B ref 37189); Tue, 04 Feb 2020 18:56:02 +0000 Original-Received: (at 37189) by debbugs.gnu.org; 4 Feb 2020 18:55:20 +0000 Original-Received: from localhost ([127.0.0.1]:44766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz3Lz-0007Ms-Qh for submit@debbugs.gnu.org; Tue, 04 Feb 2020 13:55:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz3Ly-0007Mf-3R for 37189@debbugs.gnu.org; Tue, 04 Feb 2020 13:55:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iz3Ls-00027F-Mc; Tue, 04 Feb 2020 13:55:12 -0500 Original-Received: from [176.228.60.248] (port=1158 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iz3Lr-0007sQ-8o; Tue, 04 Feb 2020 13:55:12 -0500 In-reply-to: (message from Wolfgang Scherer on Mon, 3 Feb 2020 02:16:43 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175671 Archived-At: > Cc: dgutov@yandex.ru, 37189@debbugs.gnu.org > From: Wolfgang Scherer > Date: Mon, 3 Feb 2020 02:16:43 +0100 > > Just to be clear that my original intention was only a simple bugfix > ... I'm okay with limiting these discussions only to a particular bug. I believe it was you who introduced the design issue into the discussion. We can drop that part if you don't think it's important enough. Having said that... > Per-directory vs. per-tree > ========================== ...I don't feel I understand better your view of what you describe as fundamental design problems in this area. I'm saying that after reading your description at least twice. You make many assertions and tell what these features _should_ do, but there's little explanation of _why_ these assertions are true or why the commands should do this or that. Even the first step of your argument: that there's a fundamental difference between per-directory and per-tree ignore specs is left with almost no description of these fundamental differences. I don't think I have a clear idea of why you think so. > Use cases > > 1. Ignore a file in `vc-dir-mode`. > >    Write basename of absolute filepath into ignore file for directory. > > 2. Ignore marked files in `vc-dir-mode`. > >    Write basename of relative filepath into ignore file for directory. > > 3. Ignore absolute/relative filepath with `vc-ignore`. > >    Write basename of filepath into ignore file for directory. > > 4. Ignore pattern with `vc-ignore`. > >    Write pattern unaltered into ignore file of directory. This enumerates use cases and states their requirements, but doesn't explain those requirements. I don't think I understand why sometimes the file specs need to be relative and sometimes absolute, because you just say so without any explanations. > The reference backend implementation is `vc-default-ignore`. Although > the documentation already specifies what the function should do in a > per-tree context, the original implementation strangely follows the > description of `vc-ignore` which is still per-directory. See, I don't even understand why you say vc-ignore is per-directory. That it accepts a directory as its argument doesn't yet mean it cannot support all of its subdirectories, recursively, which will make it per-tree. I'm probably missing something, but what? Once again, feel free to tell the discussion about the design is not useful and should be abandoned. I'm okay with discussing just the specific bug you have. But if we are to continue talking about design aspects, may I suggest that you explain your opinions more than you did until now? Thanks.