From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42383: 28.0.50; Two bugs with M-x compile Date: Thu, 16 Jul 2020 18:17:28 +0300 Message-ID: <83h7u7lcaf.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18732"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42383@debbugs.gnu.org, Stefan Monnier To: Gregory Heytings , Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 16 17:18:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jw5eE-0004dt-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 17:18:10 +0200 Original-Received: from localhost ([::1]:57808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw5eD-0008SW-Mm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 11:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw5e6-0008RJ-Ir for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 11:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jw5e6-00016o-9X for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 11:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jw5e6-0008DY-4t for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 11:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2020 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42383 X-GNU-PR-Package: emacs Original-Received: via spool by 42383-submit@debbugs.gnu.org id=B42383.159491267231573 (code B ref 42383); Thu, 16 Jul 2020 15:18:02 +0000 Original-Received: (at 42383) by debbugs.gnu.org; 16 Jul 2020 15:17:52 +0000 Original-Received: from localhost ([127.0.0.1]:55754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5dw-0008DA-6v for submit@debbugs.gnu.org; Thu, 16 Jul 2020 11:17:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5dv-0008Cy-6R for 42383@debbugs.gnu.org; Thu, 16 Jul 2020 11:17:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49786) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw5dn-00014s-85; Thu, 16 Jul 2020 11:17:43 -0400 Original-Received: from [176.228.60.248] (port=2120 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw5dm-0000rj-Kq; Thu, 16 Jul 2020 11:17:43 -0400 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183070 Archived-At: > Date: Thu, 16 Jul 2020 09:48:56 +0000 > From: Gregory Heytings via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > > 1. create a Makefile with a few targets > > 2. start emacs -Q > > 3. M-x compile > > 4. press TAB: the list of targets is displayed > > 5. type the first character of an existing target, and press TAB > > 6. the result is a "[No match]" > > > > This has been working correctly for years (tested with Emacs 24, 25, > > 26), and does not work anymore with Emacs 28. > > > > It seems that at step 5 above the list of completion candidates that is > > considered are subdirectories. > > > > Upon further investigation, this bug has been introduced by the patch for > bug#34330, which moved pcomplete-completions-at-point last in > shell-dynamic-complete-functions in shell.el: > > (defcustom shell-dynamic-complete-functions > '(comint-c-a-p-replace-by-expanded-history > shell-environment-variable-completion > shell-command-completion > shell-c-a-p-replace-by-expanded-directory > shell-filename-completion > comint-filename-completion > ;; Put `pcomplete-completions-at-point' last so that other > ;; functions can run before it does, see bug#34330. > pcomplete-completions-at-point) > > See https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e4d17d8cb479ffeeb7dfb7320a1432722ac8df75 . > > The obvious fix is to revert the situation (that is, to move > pcomplete-completions-at-point again before shell-filename-completion), > but I'm not sure, because bug#34330 would again exist. That being said, > I'm not sure that handling the exceptional case of filenames with '&' > characters correctly when completing in M-x shell (which is what bug#34330 > is about) justifies to break normal behavior in other situations. Indeed. Stefan, Alex: any ideas for how to fix this? This problem exists on the emacs-27 branch, so we must find a safe solution for that branch, and we must do that quickly. If we don't have any better ideas, I think we should revert that fix on emacs-27 at least. Thanks.