From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42431: 28.0.50; browse-url-of-dired-file confusing messaging Date: Sun, 09 Aug 2020 17:05:14 +0300 Message-ID: <83h7tb6hk5.fsf@gnu.org> References: <87v9ijl2ol.fsf@gnus.org> <87blk04mw8.fsf@gnus.org> <83eeoh7f68.fsf@gnu.org> <87a6z55u7j.fsf@gnus.org> <83y2mp5te0.fsf@gnu.org> <87pn80w49u.fsf@gnus.org> <87lfiow3tq.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11171"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, michael.albinus@gmx.de, 42431@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 09 16:06:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4lxi-0002nY-7n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 16:06:10 +0200 Original-Received: from localhost ([::1]:37822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4lxh-000342-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 10:06:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4lxa-00033t-SE for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 10:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4lxa-0001pi-Is for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 10:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4lxa-0003hU-Dz for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42431 X-GNU-PR-Package: emacs Original-Received: via spool by 42431-submit@debbugs.gnu.org id=B42431.159698194114191 (code B ref 42431); Sun, 09 Aug 2020 14:06:02 +0000 Original-Received: (at 42431) by debbugs.gnu.org; 9 Aug 2020 14:05:41 +0000 Original-Received: from localhost ([127.0.0.1]:33209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4lxE-0003gp-V2 for submit@debbugs.gnu.org; Sun, 09 Aug 2020 10:05:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4lxD-0003gd-AZ for 42431@debbugs.gnu.org; Sun, 09 Aug 2020 10:05:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60289) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4lx7-0001kA-2L; Sun, 09 Aug 2020 10:05:33 -0400 Original-Received: from [176.228.60.248] (port=1434 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k4lx4-0000Ir-AR; Sun, 09 Aug 2020 10:05:32 -0400 In-Reply-To: <87lfiow3tq.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 09 Aug 2020 11:45:05 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184422 Archived-At: > From: Lars Ingebrigtsen > Cc: michael.albinus@gmx.de, 42431@debbugs.gnu.org, Paul Eggert > > Date: Sun, 09 Aug 2020 11:45:05 +0200 > > Lars Ingebrigtsen writes: > > > It would be, but I think this points to an error in insert-file-contents > > itself. I'll poke around some more... > > Yup. The error signalling comes from Finsert_file_contents. If I make > this change, then the confusing messaging goes away: > > diff --git a/src/fileio.c b/src/fileio.c > index 37072d9b6b..05e262b201 100644 > --- a/src/fileio.c > +++ b/src/fileio.c > @@ -4826,7 +4826,6 @@ because (1) it preserves some marker positions and (2) it puts less data > if (!NILP (visit) && current_buffer->modtime.tv_nsec < 0) > { > /* Signal an error if visiting a file that could not be opened. */ > - report_file_errno ("Opening input file", orig_filename, save_errno); > } > Of course. And that's exactly what I meant when I suggested to convert the file:// URL to a local file name, before calling insert-file-contents. If we do that, the problem should go away. Or am I missing something?