From: Eli Zaretskii <eliz@gnu.org>
To: Brian Leung <leungbk@mailfence.com>
Cc: rpluim@gmail.com, dgutov@yandex.ru, 43117@debbugs.gnu.org
Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file
Date: Sun, 13 Sep 2020 20:34:10 +0300 [thread overview]
Message-ID: <83h7s1bmy5.fsf@gnu.org> (raw)
In-Reply-To: <1670898213.459425.1600016799389@ichabod.co-bxl> (message from Brian Leung on Sun, 13 Sep 2020 19:06:39 +0200 (CEST))
> Date: Sun, 13 Sep 2020 19:06:39 +0200 (CEST)
> From: Brian Leung <leungbk@mailfence.com>
> Cc: dgutov@yandex.ru, rpluim@gmail.com, 43117@debbugs.gnu.org
>
> > I'm not sure I understand the rationale: why would we want to replace
> > all 'if's with 'when's?
>
> I expected that people would find it easier to read 'when'/'unless' than single-clause 'if' statements. The 'when'/'unless', along with the indentation of the corresponding 'then' clause, immediately signal that there is only one possible non-nil form returned. With single-clause 'if' statements, you would have to continue reading past the 'then' clause to spot what the 'when'/'unless' and its differing indentation immediately tell you.
To go over two dozen of files and summarily replace 'if' with 'when'
for this reason sounds way too radical to me. I have no difficulties
understanding the original code, FWIW.
Is it just me? do others think such changes are a good idea?
next prev parent reply other threads:[~2020-09-13 17:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 17:46 bug#43117: [PATCH] Add .git-blame-ignore-revs file Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-31 10:16 ` Robert Pluim
2020-08-31 20:11 ` Dmitry Gutov
2020-08-31 20:34 ` Robert Pluim
2020-08-31 20:45 ` Dmitry Gutov
2020-08-31 20:57 ` Robert Pluim
2020-08-31 21:03 ` Dmitry Gutov
2020-09-13 0:42 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 14:07 ` Eli Zaretskii
2020-09-13 17:06 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 17:34 ` Eli Zaretskii [this message]
2020-09-13 17:57 ` Lars Ingebrigtsen
2020-09-13 18:49 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-18 17:03 ` Stefan Kangas
2020-10-18 17:18 ` Eli Zaretskii
2020-10-18 17:54 ` Stefan Kangas
2020-10-18 17:59 ` Eli Zaretskii
2020-10-18 18:25 ` Stefan Kangas
2020-10-18 18:41 ` Eli Zaretskii
2020-10-19 16:06 ` Stefan Kangas
2020-10-19 16:40 ` Eli Zaretskii
2020-10-20 10:38 ` Lars Ingebrigtsen
2020-10-20 12:05 ` Stefan Kangas
2021-03-12 1:07 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7s1bmy5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=43117@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=leungbk@mailfence.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).