From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Date: Wed, 30 Sep 2020 19:03:55 +0300 Message-ID: <83h7rfi74k.fsf@gnu.org> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23919"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 43714@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 18:09:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNef9-0006A6-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 18:09:03 +0200 Original-Received: from localhost ([::1]:39008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNef8-00015G-DV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 12:09:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNebG-0004Lh-MA for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 12:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNebG-0002YJ-9z for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 12:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNebG-0004Ma-5c for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160148185416712 (code B ref 43714); Wed, 30 Sep 2020 16:05:02 +0000 Original-Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 16:04:14 +0000 Original-Received: from localhost ([127.0.0.1]:60970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNeaT-0004LU-VI for submit@debbugs.gnu.org; Wed, 30 Sep 2020 12:04:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNeaS-0004LI-7B for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 12:04:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36870) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNeaJ-0002T4-Ud; Wed, 30 Sep 2020 12:04:05 -0400 Original-Received: from [176.228.60.248] (port=1939 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kNeaI-0000ab-Ur; Wed, 30 Sep 2020 12:04:03 -0400 In-Reply-To: <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> (message from Boruch Baum on Wed, 30 Sep 2020 11:28:27 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189380 Archived-At: > Date: Wed, 30 Sep 2020 11:28:27 -0400 > From: Boruch Baum > Cc: Lars Ingebrigtsen , 43714@debbugs.gnu.org > > On 2020-09-30 17:25, Eli Zaretskii wrote: > > > (auto-revert-buffers): Use save-match-data. > > > > It could be due to remote files (and file-handlers)? > > But I don't see anywhere in the code itself being evaluated in > auto-revert.el that would produce its own match-data to potentially > disturb the pre-existing state. That's what I meant: it could be hidden from plain sight. Why is that a problem to leave save-match-data alone? Does it do any harm?