From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Date: Fri, 30 Oct 2020 20:54:32 +0200 Message-ID: <83h7qba6jb.fsf@gnu.org> References: <955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at> <83mu553e0x.fsf@gnu.org> <953c6df9-59b4-8b57-0be3-600d147fe9c7@ims.co.at> <83y2k2pabb.fsf@gnu.org> <83wnzmnioj.fsf@gnu.org> <83lfg1nfv1.fsf@gnu.org> <83d01dnegn.fsf@gnu.org> <2ae49edc-098f-9ace-595d-9e29bf3d2c8b@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34963"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41852@debbugs.gnu.org, thomas.hisch@ims.co.at To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 19:55:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYZYL-0008sv-4i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 19:55:09 +0100 Original-Received: from localhost ([::1]:54080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYZYJ-00013C-Pr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 14:55:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYZYE-000135-8b for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 14:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYZYD-0002VI-Sn for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 14:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYZYD-0004Np-Rb for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 14:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41852-submit@debbugs.gnu.org id=B41852.160408409716836 (code B ref 41852); Fri, 30 Oct 2020 18:55:01 +0000 Original-Received: (at 41852) by debbugs.gnu.org; 30 Oct 2020 18:54:57 +0000 Original-Received: from localhost ([127.0.0.1]:59736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYZY9-0004NT-1a for submit@debbugs.gnu.org; Fri, 30 Oct 2020 14:54:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYZY8-0004NI-2z for 41852@debbugs.gnu.org; Fri, 30 Oct 2020 14:54:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50305) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYZY1-0002Te-8W; Fri, 30 Oct 2020 14:54:49 -0400 Original-Received: from [176.228.60.248] (port=1918 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYZY0-0004LM-JO; Fri, 30 Oct 2020 14:54:49 -0400 In-Reply-To: (message from Stefan Kangas on Fri, 30 Oct 2020 16:04:58 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192177 Archived-At: > From: Stefan Kangas > Date: Fri, 30 Oct 2020 16:04:58 +0000 > Cc: thomas.hisch@ims.co.at, 41852@debbugs.gnu.org > > > (2) that text in the header line or elsewhere in such a buffer not > > inheriting from (the remapped) header line face is unaffected, and > > I'm not sure I understand what you mean. If text-scale-mode is enabled, > typically through running e.g. `text-scale-increase', the `default' face > is scaled. The result, AFAICT, is that all faces in the buffer change > size (well, not the mode line). No, only faces that inherit from 'default' are scaled. And now so will the faces that inherit from 'header-line'. > And that makes sense since all other implicitly inherits from it, > right? No, not every face inherits from 'default', only those that inherit explicitly. A random face that is defined with defface isn't affected by text-scale-*. > This works even for anonymous faces, e.g.: > > (progn > (fundamental-mode) > (insert (propertize "foo" 'face '(:height 1.5))) > (text-scale-increase)) > > What am I missing? See above. > > Wrt (3) I assume that 'tabulated-list-mode' can already get derailed > > when a user customizes header line face to use some large or small font > > size (a scenario where face remapping is not involved at all). > > I tried customizing the `Height' for the `header-line' face, and it > seems to work as expected: > > With no text-scale-mode it is as big as it is customized to be. When I > run `text-scale-increase', it scales up accordingly (relative to its > customized size). So I don't know what, if anything, should be added > here. Since it works as expected, perhaps there is nothing to add? What Martin means, I think, is that using a larger font in header-line face might make the text below the header line in tabulated-list-mode fail to align.