From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file Date: Sat, 07 Nov 2020 12:32:14 +0200 Message-ID: <83h7q17901.fsf@gnu.org> References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18054"; mail-complaints-to="usenet@ciao.gmane.io" Cc: simenheg@runbox.com, 44303@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 07 11:33:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbLWv-0004aM-HD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 11:33:09 +0100 Original-Received: from localhost ([::1]:49062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbLWu-0005fY-FT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 05:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbLWo-0005dA-G0 for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 05:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbLWo-0005ZQ-6A for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 05:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbLWo-0007jH-2V for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 05:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Nov 2020 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44303 X-GNU-PR-Package: emacs Original-Received: via spool by 44303-submit@debbugs.gnu.org id=B44303.160474514729666 (code B ref 44303); Sat, 07 Nov 2020 10:33:02 +0000 Original-Received: (at 44303) by debbugs.gnu.org; 7 Nov 2020 10:32:27 +0000 Original-Received: from localhost ([127.0.0.1]:57993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbLWF-0007iQ-0V for submit@debbugs.gnu.org; Sat, 07 Nov 2020 05:32:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbLWD-0007iE-7t for 44303@debbugs.gnu.org; Sat, 07 Nov 2020 05:32:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56262) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbLW6-0005Ln-1C; Sat, 07 Nov 2020 05:32:19 -0500 Original-Received: from [176.228.60.248] (port=1738 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbLW3-0005AL-CA; Sat, 07 Nov 2020 05:32:17 -0500 In-Reply-To: <874km9ffiv.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 01 Nov 2020 13:06:00 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192826 Archived-At: > From: Lars Ingebrigtsen > Cc: simenheg@runbox.com, 44303@debbugs.gnu.org > Date: Sun, 01 Nov 2020 13:06:00 +0100 > > Eli Zaretskii writes: > > > But we then have this: > > > > if (modification_hooks_inhibited) > > { > > signal_after_change (BEGV, size_a, ZV - BEGV); > > update_compositions (BEGV, ZV, CHECK_INSIDE); > > } > > > > Does this not work, or fail to unlock the file? > > This does not unlock the file in the test case. Should be fixed now on master. I wonder whether we should actually cherry-pick this to the release branch. The original recipe doesn't trigger the problem there, but that's because json-pretty-print-buffer does modify the buffer on emacs-27. If it didn't, we'd probably have the same problem in Emacs 27. Thoughts?