From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17405: C-g C-g in GC does not autosave Date: Fri, 04 Dec 2020 14:33:29 +0200 Message-ID: <83h7p1eoo6.fsf@gnu.org> References: <87o8j9hjes.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24279"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 17405@debbugs.gnu.org, rms@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 04 13:35:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klAJ4-0006Cm-Sc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Dec 2020 13:35:26 +0100 Original-Received: from localhost ([::1]:51596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klAJ3-0000dM-UN for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Dec 2020 07:35:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klAIg-0000cd-SI for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 07:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60024) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klAIg-0008U9-KL for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 07:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klAIg-0004ag-H8 for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 07:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Dec 2020 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17405 X-GNU-PR-Package: emacs Original-Received: via spool by 17405-submit@debbugs.gnu.org id=B17405.160708524517578 (code B ref 17405); Fri, 04 Dec 2020 12:35:02 +0000 Original-Received: (at 17405) by debbugs.gnu.org; 4 Dec 2020 12:34:05 +0000 Original-Received: from localhost ([127.0.0.1]:43337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klAHl-0004ZR-G9 for submit@debbugs.gnu.org; Fri, 04 Dec 2020 07:34:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klAHg-0004Yt-NR for 17405@debbugs.gnu.org; Fri, 04 Dec 2020 07:34:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46065) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klAHb-0008Bg-Fh; Fri, 04 Dec 2020 07:33:55 -0500 Original-Received: from [176.228.60.248] (port=4980 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1klAHT-00014F-4R; Fri, 04 Dec 2020 07:33:47 -0500 In-Reply-To: <87o8j9hjes.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 04 Dec 2020 12:58:51 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194997 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 04 Dec 2020 12:58:51 +0100 > Cc: 17405@debbugs.gnu.org > > Richard Stallman writes: > > > I think Emacs used to be smart enough to autosave from C-g C-g > > within a GC. I guess that broke and someone decided to fix it > > by not trying to autosave. > > > > Can't we make it autosave correctly? > > I think that sounds like somewhat surprising behaviour -- why should > `C-g C-g' (at any time) autosave? Because "C-g C-g" (if you type it fast enough) triggers the so-called "emergency escape", whereby we might abort and dump core, subject to user's confirmation. See handle_interrupt in keyboard.c. The answer to Richard's question is that this "someone who decided to fix it" was Richard himself, back in Nov 2995 (see commit 118d6ca). The comment to the "not in GC" condition explains this: /* It doesn't work to autosave while GC is in progress; the code used for auto-saving doesn't cope with the mark bit. */ Maybe we should see whether this is still the case, i.e. whether auto-saving still cannot cope with the mark bit.