From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Sat, 17 Apr 2021 13:57:14 +0300 Message-ID: <83h7k5w54l.fsf@gnu.org> References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> <1869622e16688e6aedec@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24643"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47832@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 12:58:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXieT-0006KA-4I for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 12:58:13 +0200 Original-Received: from localhost ([::1]:59176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXieS-00031j-7R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 06:58:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXieI-000311-Rm for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 06:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXieI-0000Gg-CY for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 06:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXieI-0002Dh-Bb for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 06:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 10:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.16186570568491 (code B ref 47832); Sat, 17 Apr 2021 10:58:02 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 17 Apr 2021 10:57:36 +0000 Original-Received: from localhost ([127.0.0.1]:42357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXido-0002Cq-GJ for submit@debbugs.gnu.org; Sat, 17 Apr 2021 06:57:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXidj-0002CW-9N for 47832@debbugs.gnu.org; Sat, 17 Apr 2021 06:57:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60041) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXidd-0008MV-Ff; Sat, 17 Apr 2021 06:57:21 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3252 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lXida-0001GD-5P; Sat, 17 Apr 2021 06:57:19 -0400 In-Reply-To: <1869622e16688e6aedec@heytings.org> (message from Gregory Heytings on Sat, 17 Apr 2021 09:49:46 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204184 Archived-At: > Date: Sat, 17 Apr 2021 09:49:46 +0000 > From: Gregory Heytings > cc: 47832@debbugs.gnu.org > > This used to work indeed; it worked on GNU/Linux with default (non-Cairo) > builds for Emacs 24 to 27. And with Emacs 28 it doesn't work in non-Cairo builds? > Got it! :-) The commit I identified is indeed the culprit. With > USE_CAIRO, gui_init_fringe() is called in x_initialize(); without > USE_CAIRO it isn't. And gui_init_fringe() had a bug, which should now be > fixed on Windows, too. Patch attached. Thanks, but is this really all that needs to be done? How will gui_init_fringe be called in the non-Cairo builds? And what about NS?