From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36649: 27.0.50; pure space and pdumper Date: Wed, 19 May 2021 20:38:32 +0300 Message-ID: <83h7iypqsn.fsf@gnu.org> References: <4c1248b8-88cc-ca06-6bc8-9f0bb9a98c98@cs.ucla.edu> <87mtt0hupl.fsf@gnus.org> <83mtt02dyz.fsf@gnu.org> <877dk3hoko.fsf@gnus.org> <87y2cjg9mu.fsf@gnus.org> <83a6oz3lpm.fsf@gnu.org> <87lf8jg8o2.fsf@gnus.org> <838s4j3l2e.fsf@gnu.org> <87h7j7g7ft.fsf@gnus.org> <878s4jg67i.fsf@gnus.org> <834kf73iim.fsf@gnu.org> <874kf7g54z.fsf@gnus.org> <8335ur3hu8.fsf@gnu.org> <83a6oy20bj.fsf@gnu.org> <87a6oupzn1.fsf@gnus.org> <85567d83-7ec6-c5e7-81f2-74b0b310eefc@cs.ucla.edu> <83k0nxu062.fsf@gnu.org> <87y2cdjvjh.fsf@gnus.org> <83a6ottp55.fsf@gnu.org> <83pmxmpxlz.fsf@gnu.org> <549765aa-f8b9-1421-2149-42d08ee853e3@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, stefan@marxist.se, schwab@linux-m68k.org, monnier@iro.umontreal.ca, 36649@debbugs.gnu.org, larsi@gnus.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 19 19:39:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljQA9-000496-8V for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 May 2021 19:39:17 +0200 Original-Received: from localhost ([::1]:60884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljQA8-0004Wi-Ay for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 May 2021 13:39:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljQ9u-0004WJ-9W for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 13:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49077) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljQ9t-0001lH-NE for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 13:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljQ9t-00023a-Jx for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 13:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 May 2021 17:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36649-submit@debbugs.gnu.org id=B36649.16214459237854 (code B ref 36649); Wed, 19 May 2021 17:39:01 +0000 Original-Received: (at 36649) by debbugs.gnu.org; 19 May 2021 17:38:43 +0000 Original-Received: from localhost ([127.0.0.1]:60620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljQ9W-00022X-GI for submit@debbugs.gnu.org; Wed, 19 May 2021 13:38:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljQ9T-00022J-Ni for 36649@debbugs.gnu.org; Wed, 19 May 2021 13:38:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57584) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljQ9I-0001UW-MS; Wed, 19 May 2021 13:38:27 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljQ9I-0000qt-2L; Wed, 19 May 2021 13:38:24 -0400 In-Reply-To: <549765aa-f8b9-1421-2149-42d08ee853e3@cs.ucla.edu> (message from Paul Eggert on Wed, 19 May 2021 10:29:06 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206909 Archived-At: > Cc: rpluim@gmail.com, stefan@marxist.se, schwab@linux-m68k.org, > monnier@iro.umontreal.ca, 36649@debbugs.gnu.org > From: Paul Eggert > Date: Wed, 19 May 2021 10:29:06 -0700 > > On 5/19/21 8:11 AM, Eli Zaretskii wrote: > > Paul, if this kludge annoys you enough (I hope it will), please > > suggest a cleaner way out of this conundrum. > > configure.ac can define a macro that tells gmalloc.c about the kludge > situation, and gmalloc.c can refer to that macro to decide whether to > call rpl_free instead of plain 'free'. The problem is not in gmalloc.c, the problem is in every src/*.c file that calls 'free'. That's because we redirect to hybrid_free in conf_post.h, but Gnulib's stdlib.h is included after that, and it undoes that redirection: #if @GNULIB_FREE_POSIX@ # if @REPLACE_FREE@ # if !(defined __cplusplus && defined GNULIB_NAMESPACE) # undef free # define free rpl_free # endif Then the linker errors out due to unresolved externals, because there's no rpl_free. Would it work to add rpl_free to gmalloc.c, perhaps? > Also, make sure that hybrid_free preserves errno. If this is the best solution, then okay, will do. I hoped something cleaner could be possible.