From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>, Kenichi Handa <handa@gnu.org>
Cc: 17758@debbugs.gnu.org, tobias.bora@gmail.com
Subject: bug#17758: 24.3; The line isn't wrapped during printing if it contains non ascii chars
Date: Sat, 29 May 2021 09:38:37 +0300 [thread overview]
Message-ID: <83h7im6o42.fsf@gnu.org> (raw)
In-Reply-To: <87v972rtfc.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 29 May 2021 07:38:15 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sat, 29 May 2021 07:38:15 +0200
> Cc: 17758@debbugs.gnu.org
>
> (defun ps-mule-plot-string (from to &optional _bg-color)
> [...]
> (ascii-or-latin-1 "[\000-\377]+")
> [...]
> ((looking-at ascii-or-latin-1)
> (let ((nchars (- (min (match-end 0) stop) (point))))
> (setq width (* average-width nchars))
> (if (< ps-width-remaining (+ run-width width))
> (setq nchars (truncate (- ps-width-remaining run-width)
> average-width)
> run-width (+ run-width (* nchars average-width))
> endpos (+ (point) nchars))
> (setq run-width (+ run-width width))
> (forward-char nchars))))
>
> (t
> (while (and (< (point) stop) (not endpos))
> (setq width (char-width (following-char)))
> (if (< ps-width-remaining (+ run-width width))
> (setq endpos (point))
> (setq run-width (+ run-width width))
> (forward-char 1))))))
>
> This is trying to do word line wrapping if we're looking at ASCII or
> Latin-1 text. (I'm not sure I understand the reasoning behind that, but
> perhaps it's because we don't want to wrap (say) Chinese text? But...
> what's so special about Latin-1? Why not fold Cyrillic?)
>
> Anyway, the regexp is buggy, why is why this doesn't work. I've now
> fixed this in Emacs 28.
I'm not sure I understand the fix, can you explain it?
Regarding the reason for limiting ourselves to Latin-1: AFAIR, ps-mule
doesn't support non-ASCII characters outside Latin-1 and CJK character
sets. Perhaps this is the reason for this code? But the only expert
on this is Handa-san (CC'ed): perhaps he could help us understand what
the code is doing?
next prev parent reply other threads:[~2021-05-29 6:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 21:21 bug#17758: 24.3; The line isn't wrapped during printing if it contains non ascii chars Tobias Bora
2016-02-13 11:07 ` Marcin Borkowski
2021-05-29 5:38 ` Lars Ingebrigtsen
2021-05-29 6:38 ` Eli Zaretskii [this message]
2021-05-29 6:41 ` Lars Ingebrigtsen
2021-05-29 7:01 ` Eli Zaretskii
2021-05-29 8:19 ` Andreas Schwab
2021-05-29 8:09 ` Mattias Engdegård
2021-05-30 4:04 ` Lars Ingebrigtsen
2021-05-30 10:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7im6o42.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17758@debbugs.gnu.org \
--cc=handa@gnu.org \
--cc=larsi@gnus.org \
--cc=tobias.bora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).