From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33847: 27.0.50; emacsclient does not find server socket Date: Thu, 22 Jul 2021 20:30:20 +0300 Message-ID: <83h7gm2r4j.fsf@gnu.org> References: <8a6fc59c-08b3-e274-4fb1-74674c79540a@cs.ucla.edu> <9ebcad22-2cdb-46fb-4be9-efc4ad234b6d@cs.ucla.edu> <27d2f2eb-8956-4088-f3ec-5ff6c2cf2e8f@cs.ucla.edu> <87eeo27v6k.fsf@gnus.org> <83lfi79klf.fsf@gnu.org> <831rjya5yy.fsf@gnu.org> <8333533f-08ec-acd4-2fbf-f06e78591e98@cs.ucla.edu> <83v9h99awv.fsf@gnu.org> <878s1yjy20.fsf@gnus.org> <83lf5y2t78.fsf@gnu.org> <878s1yi8jc.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20955"; mail-complaints-to="usenet@ciao.gmane.io" Cc: teika@gmx.com, eggert@cs.ucla.edu, 33847@debbugs.gnu.org, ulm@gentoo.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 22 19:31:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6cXO-0005Fz-DD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jul 2021 19:31:10 +0200 Original-Received: from localhost ([::1]:45694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6cXM-0005bm-F1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jul 2021 13:31:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6cXG-0005bW-4U for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 13:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58246) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6cXF-0004QJ-T6 for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 13:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6cXF-0002uA-PF for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 13:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jul 2021 17:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33847-submit@debbugs.gnu.org id=B33847.162697506011158 (code B ref 33847); Thu, 22 Jul 2021 17:31:01 +0000 Original-Received: (at 33847) by debbugs.gnu.org; 22 Jul 2021 17:31:00 +0000 Original-Received: from localhost ([127.0.0.1]:41559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6cX8-0002to-N3 for submit@debbugs.gnu.org; Thu, 22 Jul 2021 13:31:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6cX3-0002tY-5f for 33847@debbugs.gnu.org; Thu, 22 Jul 2021 13:30:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59286) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6cWw-000490-AT; Thu, 22 Jul 2021 13:30:42 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6cWu-0000SY-N2; Thu, 22 Jul 2021 13:30:42 -0400 In-Reply-To: <878s1yi8jc.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 22 Jul 2021 19:05:11 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210534 Archived-At: > From: Lars Ingebrigtsen > Cc: eggert@cs.ucla.edu, teika@gmx.com, 33847@debbugs.gnu.org, ulm@gentoo.org > Date: Thu, 22 Jul 2021 19:05:11 +0200 > > Eli Zaretskii writes: > > > Looks like you didn't attach the right patch? > > Yup; 2nd attempt now. Thanks. It looks like the w32-related aspect of this is easier to resolve than I originally thought, because almost all of the changes are in the SOCKETS_IN_FILE_SYSTEM part, which is not compiled for the MS-Windows build. The only potential issues I spotted are: > --- a/lib-src/emacsclient.c > +++ b/lib-src/emacsclient.c > @@ -80,6 +80,7 @@ Copyright (C) 1986-1987, 1994, 1999-2021 Free Software Foundation, Inc. > #include > #include > > +#include <<<<<<<<<<<<<<<<<<<<<<<<<<< > #include > #include > #include We cannot unconditionally include acl.h on MS-Windows, so this has to be #ifdef'ed away. > @@ -91,6 +92,10 @@ Copyright (C) 1986-1987, 1994, 1999-2021 Free Software Foundation, Inc. > # pragma GCC diagnostic ignored "-Wformat-truncation=2" > #endif > > +#ifndef O_PATH > +# define O_PATH O_SEARCH <<<<<<<<<<<<<<<<<<<<<<<<< > +#endif This is probably harmless, but I'd like to #ifdef it away as well. > diff --git a/lib/gnulib.mk.in b/lib/gnulib.mk.in > index 07736f9b8b..0b9aaf6d9e 100644 > --- a/lib/gnulib.mk.in > +++ b/lib/gnulib.mk.in > @@ -98,6 +98,7 @@ > # fcntl \ > # fcntl-h \ > # fdopendir \ > +# file-has-acl \ > # filemode \ > # filename \ > # filevercmp \ > @@ -1788,6 +1789,16 @@ EXTRA_libgnu_a_SOURCES += fdopendir.c > endif > ## end gnulib module fdopendir > > +## begin gnulib module file-has-acl > +ifeq (,$(OMIT_GNULIB_MODULE_file-has-acl)) > + > +libgnu_a_SOURCES += file-has-acl.c > + > +EXTRA_DIST += acl-internal.h > + > +endif > +## end gnulib module file-has-acl > + > ## begin gnulib module filemode > ifeq (,$(OMIT_GNULIB_MODULE_filemode)) > We need to add stuff to nt/gnulib-cfg.mk to omit building the file-has-acl.c file on MS-Windows. (I can do that after the rest is installed.) The only other worry is whether we indeed have ways to test this thoroughly enough on Posix systems.