unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: larsi@gnus.org, jasonrumney@gmail.com, 6918-done@debbugs.gnu.org,
	kzhr@d1.dion.ne.jp
Subject: bug#6918: Colors of xbm image are swapped on Windows
Date: Sat, 06 Nov 2021 13:35:42 +0200	[thread overview]
Message-ID: <83h7cpbjox.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkA1=g5PPbzSDJTuQnrO8t4Avq91=E1tEDN600mixNrVw@mail.gmail.com> (message from Stefan Kangas on Fri, 5 Nov 2021 06:26:01 -0700)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 5 Nov 2021 06:26:01 -0700
> Cc: Jason Rumney <jasonrumney@gmail.com>, larsi@gnus.org, kzhr@d1.dion.ne.jp, 
> 	6918@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Jason Rumney <jasonrumney@gmail.com>
> >> Date: Thu, 10 Oct 2019 19:59:46 +1300
> >> Cc: Lars Ingebrigtsen <larsi@gnus.org>, kzhr@d1.dion.ne.jp, 6918@debbugs.gnu.org
> >>
> >> On Fri, 27 Sep 2019 at 17:30, Eli Zaretskii <eliz@gnu.org> wrote:
> >> >
> >> > How do you suggest to test the proposed change, to make sure it
> >> > doesn't break something else?  Any pointers to those monochrome PBM
> >> > icons used in the past, for example, or any other files?
> >>
> >> Are the icons not still under etc/images?  It looks like they are to me.
> >
> > There are *.pbm icons in etc/images/, and then there are *.ico files
> > in nt/icons/.  Which ones did you have in mind?
> 
> (That was in 2019, but Jason never replied back.)
> 
> My guess is the *.pbm icons - as far as I can tell, Emacs doesn't have
> support for the .ico ones without ImageMagick.  The patch is also about
> the pbm code, AFAICT.  So I would check them.

I checked them after the change, and they still display correctly.  So
I've now installed the change on master, and I'm closing this bug.

Thanks.





      reply	other threads:[~2021-11-06 11:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26  8:42 bug#6918: Colors of xbm image are swapped on Windows Kazuhiro Ito
2019-09-26 17:59 ` Lars Ingebrigtsen
2019-09-26 18:31   ` Eli Zaretskii
2019-09-26 18:34     ` Lars Ingebrigtsen
2019-09-26 18:44       ` Eli Zaretskii
2019-09-26 21:38         ` Jason Rumney
2019-09-27  5:30           ` Eli Zaretskii
2019-10-10  6:59             ` Jason Rumney
2019-10-10  8:17               ` Eli Zaretskii
2021-11-05 13:26                 ` Stefan Kangas
2021-11-06 11:35                   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h7cpbjox.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=6918-done@debbugs.gnu.org \
    --cc=jasonrumney@gmail.com \
    --cc=kzhr@d1.dion.ne.jp \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).