From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Date: Thu, 06 Jan 2022 22:17:06 +0200 Message-ID: <83h7ag7h6l.fsf@gnu.org> References: <878s7z4ihk.fsf@gmail.com> <87r1ecilqn.fsf@haukerehfeld.de> <87a6l0cjyj.fsf@mail.linkov.net> <86zgo865qc.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12190"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46374@debbugs.gnu.org, hauke@haukerehfeld.de, monnier@iro.umontreal.ca, tino.calancha@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 06 21:17:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5ZCA-0002yD-RG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jan 2022 21:17:11 +0100 Original-Received: from localhost ([::1]:48346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5ZC9-0006vo-DM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jan 2022 15:17:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5ZC2-0006vc-Uq for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 15:17:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5ZC2-00080N-Lp for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 15:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5ZC2-0002RV-Ds for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 15:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jan 2022 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46374 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 46374-submit@debbugs.gnu.org id=B46374.16415002219375 (code B ref 46374); Thu, 06 Jan 2022 20:17:02 +0000 Original-Received: (at 46374) by debbugs.gnu.org; 6 Jan 2022 20:17:01 +0000 Original-Received: from localhost ([127.0.0.1]:42425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5ZC0-0002R8-V8 for submit@debbugs.gnu.org; Thu, 06 Jan 2022 15:17:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5ZBz-0002Qp-53 for 46374@debbugs.gnu.org; Thu, 06 Jan 2022 15:16:59 -0500 Original-Received: from [2001:470:142:3::e] (port=54726 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5ZBt-0007iP-3p; Thu, 06 Jan 2022 15:16:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aDcAYaCqg/LHHwD+FYWYTfRqaLAB/EHWDKHT3yBjlAI=; b=b+92e0NjdyUv fjjf6UWAapYXdylPSXfO/gpBhI61YS7QlR+okYV9zbWlpBl0xX0pGCTvZlD/pPbt0HLJEv2VZ4u+z P+rnqqK+DnxkwJmmIHLA2/ZbvA2PwSYl65RXa+LHW3j1dpXr2dLVQAO2phTkjbtKyWVHth9UfTc2D TBkqT13WcudWhlebytGsDbj0WmY0w6g0T42LYEnWoRtPb/LsPNWPtZ8spiuw/nOKUivYT1+lH0DUZ o560ncIRJ+HPLXwpA4RBjrBymKuJ8noBeiump0nqw7n18G5WdD/iwWCd2fP5hXyHOHMPpViLtuYYW hsAPgUeszPmUi5P+YetKOA==; Original-Received: from [87.69.77.57] (port=4473 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5ZBt-0003FU-4D; Thu, 06 Jan 2022 15:16:53 -0500 In-Reply-To: <86zgo865qc.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 06 Jan 2022 21:09:47 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223748 Archived-At: > From: Juri Linkov > Date: Thu, 06 Jan 2022 21:09:47 +0200 > Cc: 46374@debbugs.gnu.org, Hauke Rehfeld , > Tino Calancha > > > It's actually easy to distinguish this specific case: when the pred is > > passed directly to `save-some-buffers` we don't need to do the "call > > PRED to get the actual predicate" dance, since the caller could just as > > well do that dance before calling us if that's what they want. > > > > IOW, the test for `save-some-buffers-function` is only needed for those > > functions that come from `save-some-buffers-default-predicate`. > > > > Any objection to the patch below (which also aligns the code closer > > with the doc since the doc of `save-some-buffers` doesn't mention the > > use of the `save-some-buffers-function` property on its `pred` > > argument). > > Then this change needs to be in the release branch, so users won't start > relying on the unintended case of using of the `save-some-buffers-function` > property on the `pred` argument. I don't see the message to which you are responding, so I cannot tell whether the patch you have in mind is appropriate for the release branch.