From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53207: 28.0.91; create-lockfiles nil breaks file change detection Date: Fri, 28 Jan 2022 16:30:29 +0200 Message-ID: <83h79oc4qi.fsf@gnu.org> References: <509ddd0f-589c-45b0-9b60-5820f4c1d716@www.fastmail.com> <83sftr3nyx.fsf@gnu.org> <83h7a73fab.fsf@gnu.org> <87fspqz94l.fsf@gmx.de> <87v8ylmnie.fsf@gnus.org> <837db11he9.fsf@gnu.org> <83h79pdrlh.fsf@gnu.org> <877dakht8k.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36443"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rgm@gnu.org, ejb@ql.org, 53207@debbugs.gnu.org To: Lars Ingebrigtsen , michael.albinus@gmx.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 28 15:43:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDST4-0009K2-Bk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jan 2022 15:43:14 +0100 Original-Received: from localhost ([::1]:50348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDST2-0004XH-VI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jan 2022 09:43:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDSIK-0008Ji-Tn for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 09:32:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36809) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDSIE-000521-Oq for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 09:32:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDSIE-0006Lc-N8 for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 09:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jan 2022 14:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53207 X-GNU-PR-Package: emacs Original-Received: via spool by 53207-submit@debbugs.gnu.org id=B53207.164338028022101 (code B ref 53207); Fri, 28 Jan 2022 14:32:02 +0000 Original-Received: (at 53207) by debbugs.gnu.org; 28 Jan 2022 14:31:20 +0000 Original-Received: from localhost ([127.0.0.1]:57945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDSHU-0005hY-LA for submit@debbugs.gnu.org; Fri, 28 Jan 2022 09:31:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDSHT-0005bh-5b for 53207@debbugs.gnu.org; Fri, 28 Jan 2022 09:31:15 -0500 Original-Received: from [2001:470:142:3::e] (port=56104 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDSHN-0004sj-N2; Fri, 28 Jan 2022 09:31:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U7SUBLo7gLCGG+PellICi/4FY6SN7KplJTY55GBxiV8=; b=E8fWHy+ItAq8 bT5vtfnQq13eTIAyT6oPKHgTSOJ7RYMAA/ZqUHHxFBzYl1bhCbmvXyTMGNLp/GbWK0QL7adQFjmRn 7h30zuchnXyGvt0LVapIsdvKAsVlrHoCmMrxc1QEcnVBGKLajxQmAeDVJGgnnp2BjoUbpuVFJ/ZTe XTthpDsE98MLLOuuetXxIVnZujsLrPMUaKOe6EKmnTjJaEJ+zOum5uw+fORwhjLK6MsSgHpd9h/O+ xEUIcVlmEi7Xvcd3Y+BvpBhDm8Ua57GvjYOv705+rDRVqJrqZluB+7i04MyQNxiW6ZRNQCrepoSTT bHbszhivm0ZSdyKOWAW8Jw==; Original-Received: from [87.69.77.57] (port=2799 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDSGm-0006aJ-TP; Fri, 28 Jan 2022 09:30:54 -0500 In-Reply-To: <877dakht8k.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 28 Jan 2022 14:42:19 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225455 Archived-At: > From: Lars Ingebrigtsen > Cc: rgm@gnu.org, ejb@ql.org, michael.albinus@gmx.de, 53207@debbugs.gnu.org > Date: Fri, 28 Jan 2022 14:42:19 +0100 > > Eli Zaretskii writes: > > > Lars, what shall we do about this bug report? Should we document the > > current behavior, or should we move the call to > > userlock--ask-user-about-supersession-threat out of Flock_file? This > > should be resolved before the next pretest, I think. > > I think we should restore the old behaviour, so that setting > create-lockfiles to nil doesn't break file change detection. I think > that means that we have to move > userlock--ask-user-about-supersession-threat out of Flock_file, yes. Michael, could you please suggest a patch along these lines? The changeset which moved userlock--ask-user-about-supersession-threat into Flock_file and put that under the create-lockfiles condition was your change to support locking remote files.