From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back Date: Sun, 30 Jan 2022 20:17:26 +0200 Message-ID: <83h79l9jgp.fsf@gnu.org> References: <87czn1gfb1.fsf@web.de> <838rxo0zk7.fsf@gnu.org> <86czk9kxm8.fsf@mail.linkov.net> <83ilu19n31.fsf@gnu.org> <86leyxjg7m.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29199"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, gregory@heytings.org, monnier@iro.umontreal.ca, 51883@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 30 19:18:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEEmW-0007Rw-5E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 19:18:32 +0100 Original-Received: from localhost ([::1]:33970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEEmV-00026Q-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 13:18:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEEmA-00026C-TI for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 13:18:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEEm2-0000fT-0o for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 13:18:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEEm1-00045p-O8 for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 13:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jan 2022 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51883-submit@debbugs.gnu.org id=B51883.164356666915712 (code B ref 51883); Sun, 30 Jan 2022 18:18:01 +0000 Original-Received: (at 51883) by debbugs.gnu.org; 30 Jan 2022 18:17:49 +0000 Original-Received: from localhost ([127.0.0.1]:37606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEElo-00045K-Hs for submit@debbugs.gnu.org; Sun, 30 Jan 2022 13:17:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEEll-000455-QB for 51883@debbugs.gnu.org; Sun, 30 Jan 2022 13:17:47 -0500 Original-Received: from [2001:470:142:3::e] (port=51952 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEElb-0000di-2O; Sun, 30 Jan 2022 13:17:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GRU+jp1AA69bpcb/XP5Jbx5OoH/9EH+DK2sxYxwjvC0=; b=NgXvqs+dhX9w /WOkya8rATllfRFigfOKntP8fkeKl1/yuT1nkfoZaHJt6qCUr8gNPQhCbBgcLc81PznNLJSfggYh1 1+HxYlG3SmifQ5dKYhPWmChgxKQ7pbI6FZjBLZkts6b0/bLeNnjYv5r38FP3rCIae460lCMm8tlZd O4ftXTllwkBBvXC0zz6fouQLHrlfPHNpLy3LK/TtxYZotjqxMYL4jKBS9+QrZb/8KP/Hj+Ru2PERR tvHwupV+bMX/fn8IMdxWrxONPu7Dt1zXMqo1128ZBSedV8Df71ua3eLrisioDuPwxvTV9gH/Ei0f6 O67YUET8oKQWC0QNtM35uA==; Original-Received: from [87.69.77.57] (port=2838 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEElY-0000df-RD; Sun, 30 Jan 2022 13:17:34 -0500 In-Reply-To: <86leyxjg7m.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 30 Jan 2022 19:17:30 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225622 Archived-At: > From: Juri Linkov > Cc: monnier@iro.umontreal.ca, michael_heerdegen@web.de, > gregory@heytings.org, 51883@debbugs.gnu.org > Date: Sun, 30 Jan 2022 19:17:30 +0200 > > >> So all concerns raised by Eli are addressed now > >> that make possible to enable it by default > >> as was discussed on emacs-devel: > > > > Once again, please do NOT enable this by default, I didn't agree to > > that. This feature should remain disabled by default for some time, > > until we have enough information to discuss whether it should be > > turned on by default. As discussed and agreed during its development. > > But after the recent discussion it was agreed to enable it by default > after fixing raised concerns. Everything is fixed now. > Should we restart the same discussion again? I see no need to restart that discussion, since we won't hear anything new in it. We made a decision back then, and there's no burning reason to change that decision, except that some people would like to have that feature turned on -- they can tun it on in their customizations. We discuss stuff and make decisions, and we should stick to our decisions unless they turn out to be grave mistakes, which this one isn't. > >> @item C-x 5 u > >> @kindex C-x 5 u > >> @findex undelete-frame > >> -@findex undelete-frame-mode > >> -When @code{undelete-frame-mode} is enabled, undelete one of the 16 > >> -most recently deleted frames. Without a prefix argument, undelete the > >> -most recently deleted frame. With a numerical prefix argument between > >> -1 and 16, where 1 is the most recently deleted frame, undelete the > >> -corresponding deleted frame. > >> +@findex undelete-frame-max > >> +Undelete one of the recently deleted frames. The user option > > > > "One of the recently deleted frames" sounds like Emacs arbitrarily > > decides which one. Which is not what you wanted to say, surely. > > This was copied from old text: "undelete one of the 16 most recently deleted frames". Does that mean we must blindly copy it, even if it is confusing? > >> +(defcustom undelete-frame-max 1 > >> + "Maximum number of deleted frames before oldest are thrown away." > > > > This doesn't say how to disable the feature. > > This feature can be disabled by customizing it to 0. I know. But the doc string keeps silent on that. > >> (bindings--define-key menu [undelete-last-deleted-frame] > >> '(menu-item "Undelete Frame" undelete-frame > >> - :enable (and undelete-frame-mode > >> - (car undelete-frame--deleted-frames)) > >> + :visible (car undelete-frame--deleted-frames) > > > > I think Gregory didn't like the disappearing item, and preferred it to > > be visible at all times, even if disabled. > > The invisible item makes the already overly long menu shorter, > especially for users who don't use frames. So you basically say we should disregard Gregory's opinion and prefer yours?