From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default Date: Sat, 26 Feb 2022 17:24:01 +0200 Message-ID: <83h78lps6m.fsf@gnu.org> References: <87ilt3456u.fsf@cassou.me> <87ee3rxhuj.fsf@gnus.org> <83ee3rqgia.fsf@gnu.org> <87y21zw2ll.fsf@gnus.org> <83bkyvqet5.fsf@gnu.org> <871qzrw0ni.fsf@gnus.org> <838rtzqdt4.fsf@gnu.org> <87bkytvfcz.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33298"; mail-complaints-to="usenet@ciao.gmane.io" Cc: damien@cassou.me, 54156@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 26 16:25:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNyx9-0008Y8-PR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Feb 2022 16:25:48 +0100 Original-Received: from localhost ([::1]:59910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNyx8-0001Dl-5M for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Feb 2022 10:25:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNywQ-0001Ch-OC for bug-gnu-emacs@gnu.org; Sat, 26 Feb 2022 10:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNywQ-0002YV-F6 for bug-gnu-emacs@gnu.org; Sat, 26 Feb 2022 10:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNywQ-0005sP-3H for bug-gnu-emacs@gnu.org; Sat, 26 Feb 2022 10:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Feb 2022 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 54156-submit@debbugs.gnu.org id=B54156.164588906622534 (code B ref 54156); Sat, 26 Feb 2022 15:25:02 +0000 Original-Received: (at 54156) by debbugs.gnu.org; 26 Feb 2022 15:24:26 +0000 Original-Received: from localhost ([127.0.0.1]:56150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNyvq-0005rO-AG for submit@debbugs.gnu.org; Sat, 26 Feb 2022 10:24:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNyvo-0005r8-MU for 54156@debbugs.gnu.org; Sat, 26 Feb 2022 10:24:25 -0500 Original-Received: from [2001:470:142:3::e] (port=55620 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNyvi-0002Ue-Ke; Sat, 26 Feb 2022 10:24:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PqX5f8M2ybEOCQDx3hAGNzFaM56QjLmCNAr0Ph9xSqg=; b=V2yT5LRlJSFg 5O+bDrW5dOZ+aaBY7R+pYmgM4fDO4ciRmouXMYftdF3ibP0ndlhcVCtCdZ1Ng+wDqmCAjJa1UrQ6y L+4j/kkSFsw9QVxMJdZDINKXjmiKfl7F99JrrqdXoAgIh2RGeKPr/j9YWvapTKI1MA4qzSBU2YlF1 P5gJoHaRHMzPiUsPZF6+ZMUuzWTQkto2ZK1sMYpWGWgoRCYIJ9kV9626U8ugp1XwLoG66m3w0k2eR 1nlg1rWX+T88uEsCBcMnvfwr07ZK4sQ3jjeP9+lg0XWD9G1hrt+DBfwkbxpbHYAXzNNzPPUkr3J37 lC0nbREetDG4U6r7HhFEzw==; Original-Received: from [87.69.77.57] (port=1569 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNyvh-00043b-Vh; Sat, 26 Feb 2022 10:24:18 -0500 In-Reply-To: <87bkytvfcz.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 26 Feb 2022 16:04:28 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227678 Archived-At: > From: Lars Ingebrigtsen > Cc: damien@cassou.me, 54156@debbugs.gnu.org > Date: Sat, 26 Feb 2022 16:04:28 +0100 > > Eli Zaretskii writes: > > > So we need a special trick to override defface with 'unspecified', and > > that trick is this call: > > > > (set-face-attribute 'region t :background 'unspecified) > > > > This is handled specially in internal-set-lisp-face-attribute to do > > what Damien wants. > > So perhaps set-face-attribute should do that automatically when handed a > nil value? The fact that we handle nil as 'unspecified' in the case of the color is for compatibility with Emacs 20. In Emacs 21 and later, a color cannot be nil. This is well-documented: a color must be a string or 'unspecified'. I don't think we want to resurrect that old convention of nil; it's just that Damien and others will have to get used to not using nil for a color.