From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 54493@debbugs.gnu.org, awrhygty@outlook.com
Subject: bug#54493: 27.2; image-convert :data broken
Date: Mon, 21 Mar 2022 18:59:48 +0200 [thread overview]
Message-ID: <83h77rfdh7.fsf@gnu.org> (raw)
In-Reply-To: <8735jbtgas.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 21 Mar 2022 17:35:07 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 21 Mar 2022 17:35:07 +0100
> Cc: 54493@debbugs.gnu.org
>
> awrhygty@outlook.com writes:
>
> > I tried to view non-native image files.
> > I need not only to set variables, but also to modify a function.
> > The externally converted data is broken by automatic code-conversion.
>
> I can reproduce this in Emacs 27.2, but not on the trunk, so it looks
> like this has been fixed. Here's my test case:
>
> (insert-image
> (create-image
> (with-temp-buffer
> (set-buffer-multibyte nil)
> (insert-file-contents "/home/larsi/src/WebKit/LayoutTests/fast/css/resources/bikes.bmp")
> (buffer-string))
> nil t :format 'image/bmp))
What if you evaluate this first:
(set-default-coding-systems 'utf-8-dos)
Does it still work for you? The OP is on MS-Windows, where the
default decodes the CRFL EOLs, something we shouldn't do with image
data.
In general, I believe explicitly binding coding-system-for-read, as
the OP suggested, is better than relying on some code somewhere that
just happens to let this work (on some systems).
next prev parent reply other threads:[~2022-03-21 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 13:02 bug#54493: 27.2; image-convert :data broken awrhygty
2022-03-21 16:35 ` Lars Ingebrigtsen
2022-03-21 16:59 ` Eli Zaretskii [this message]
2022-03-21 17:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h77rfdh7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54493@debbugs.gnu.org \
--cc=awrhygty@outlook.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).