From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57129: 29.0.50; Improve behavior of conditionals in Eshell Date: Wed, 17 Aug 2022 14:08:44 +0300 Message-ID: <83h72bdt4z.fsf__43043.7669668876$1660735447$gmane$org@gnu.org> References: <1871347.6tgchFWduM@nimes> <838rnofgad.fsf@gnu.org> <4165399.mogB4TqSGs@nimes> <83wnb8dukz.fsf@gnu.org> <83o7wkdqsh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17001"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bug-gnulib@gnu.org, larsi@gnus.org, bruno@clisp.org, 57129@debbugs.gnu.org, jporterbugs@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 17 13:24:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOH9T-0004Dd-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 13:23:59 +0200 Original-Received: from localhost ([::1]:58190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOH9S-0001fm-M9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 07:23:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOGvy-0008Js-9b for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 07:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOGvy-0006h1-0G for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 07:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOGvx-0002GG-OC for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 07:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2022 11:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57129 X-GNU-PR-Package: emacs Original-Received: via spool by 57129-submit@debbugs.gnu.org id=B57129.16607345488624 (code B ref 57129); Wed, 17 Aug 2022 11:10:01 +0000 Original-Received: (at 57129) by debbugs.gnu.org; 17 Aug 2022 11:09:08 +0000 Original-Received: from localhost ([127.0.0.1]:49546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOGv5-0002F2-Ne for submit@debbugs.gnu.org; Wed, 17 Aug 2022 07:09:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOGv1-0002ET-9K for 57129@debbugs.gnu.org; Wed, 17 Aug 2022 07:09:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOGut-0006ZI-04; Wed, 17 Aug 2022 07:08:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3wgnObi32SXFt8hy0+wZ9NSUqVTKvQWjqKztMnz9gdA=; b=XD4IWY1WriL0 21w50v8My2OX90+cKskHK+Jxkai/eP0e37wiVdq6QgOf7q7mqJTIgHPXbHzWc+wJbOGC64RFh/SqB /c5X3/F4YlXpLjEqAN7QdbeTCZucTOVqQkcPPCI7m3wdH9ErpEsHRXnIk9mPfr6wAfJg1YoA2uwds URrtjL71GCwPIdjVy4aib/ByA0DFTTbC9eTOXLgW5Mlf7CqhY4UiQ9UiIQGZUJbTF3QBez8OUHNc5 +CmVkGvrbDwxKKFpWHd0ED913G7rCoZ7NeIn97u4DWDG0abPf9PlSIWCevD3p4HPDSr4DD+4ALcta Dryr8ldbBrXzhf6y9mkaxA==; Original-Received: from [87.69.77.57] (port=2404 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOGus-0001yC-DT; Wed, 17 Aug 2022 07:08:54 -0400 In-Reply-To: (message from Paul Eggert on Tue, 16 Aug 2022 12:11:24 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240049 Archived-At: > Date: Tue, 16 Aug 2022 12:11:24 -0700 > Cc: bruno@clisp.org, bug-gnulib@gnu.org, larsi@gnus.org, > 57129@debbugs.gnu.org, jporterbugs@gmail.com > From: Paul Eggert > > > Thanks, but why not use 'random' instead? Emacs does have it on all > > platforms, including MS-Windows. AFAIU, it's better than 'rand'. > > If the code used 'random' then the Gnulib 'tempname' module would need > to add a dependency on the Gnulib 'random' module, which would in turn > add a cascading dependency on Gnulib's 'random_r' module. It's better to > avoid this dependency if we can easily do so. > > Come to think of it, we don't need to use 'rand' either, since > tempname.c already has a good-enough pseudorandom generator. I installed > into Gnulib the attached patch, which I hope fixes the Emacs problem > without changing glibc's generated code (once this gets migrated back > into glibc). Thanks. Would it be possible to cherry-pick this to the emacs-28 branch, so that Emacs 28.2 would have this fixed?