From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59165: 29.0.50; [PATCH] Ibuffer directory filter not buffer aware Date: Thu, 10 Nov 2022 11:36:18 +0200 Message-ID: <83h6z7rw19.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27842"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59165@debbugs.gnu.org To: Gabriel , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 10:37:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot3zt-00071g-4U for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 10:37:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot3zh-0006tY-Se; Thu, 10 Nov 2022 04:37:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot3zb-0006rr-S1 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:37:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot3zb-00043z-3y for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:37:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ot3za-0004Ji-8k for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59165 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59165-submit@debbugs.gnu.org id=B59165.166807299316557 (code B ref 59165); Thu, 10 Nov 2022 09:37:02 +0000 Original-Received: (at 59165) by debbugs.gnu.org; 10 Nov 2022 09:36:33 +0000 Original-Received: from localhost ([127.0.0.1]:41898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot3z7-0004Iz-8j for submit@debbugs.gnu.org; Thu, 10 Nov 2022 04:36:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot3z4-0004Im-VI for 59165@debbugs.gnu.org; Thu, 10 Nov 2022 04:36:31 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot3yy-0003bH-F2; Thu, 10 Nov 2022 04:36:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bvc4kw4MheWiAix5sPd/q4T+7qh2wcwrNyKe/ek8+oQ=; b=n+ZDfvmT2bU/ 6xdI3qvV+RzdrXz20OsWOajLfB6mXHeg5/GejfbK3Ap8KF3kAiy8Kx3gh/rWcie7uDm8e6dl+JRuD xQcfPv40zU3BUr/bDvIRVDGhXLTUUz8f+bdBFxJGtY9QAA/fgXWybW1XdXSD4btV+22Gyuu98lbjG NRc/mQr5VOHhdb+p13CqOVvJmeSBQZBrP26/o6FIt1iriXzqzypvybLJ/3qpnuoHKM7oKqN7mOIGm LwzWwXSMFCnAm7gCa7VxpDbQzPH4eEfTueqIg5PDDq2XvY4B3xfc5k4snoObyfTC/EF3HGTvci9lr KtVePXqLgNY06deeydizIA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot3ys-0004C3-Rv; Thu, 10 Nov 2022 04:36:21 -0500 In-Reply-To: (message from Gabriel on Thu, 10 Nov 2022 06:22:23 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247497 Archived-At: > From: Gabriel > Date: Thu, 10 Nov 2022 06:22:23 -0300 > > Description: > The ibuffer directory filter is not buffer aware for buffers not > visiting files. This bug seems to be introduced by commit 3ef18c7a213, > which made the `default-directory` no longer run within > `with-current-buffer`. > > Steps: > 1. emacs -Q (29.0.50 master d04433b96215d7d3387573f19cc315de86f2341a) > 2. M-x dired /home/myuser/foo > 3. M-x compile ls -lha > 4. M-x ibuffer > 5. / F /home/myuser/foo > > Expected: filter is applied and two buffers are shown: `foo` and > `*compilation*`. > > Actual: only buffer `foo` is shown. > > Patch: > Below there is a proposed patch. I did a quick inspection and could not > find similar regressions in other ibuffer filters. Stefan, can you please look into this?