From: Eli Zaretskii <eliz@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: 59603@debbugs.gnu.org
Subject: bug#59603: 28.1.90; `ucs-normalize-string' fails to work
Date: Sat, 26 Nov 2022 11:23:51 +0200 [thread overview]
Message-ID: <83h6ymt6fs.fsf@gnu.org> (raw)
In-Reply-To: <87sfi6jdd5.fsf@localhost> (message from Ihor Radchenko on Sat, 26 Nov 2022 09:04:22 +0000)
> From: Ihor Radchenko <yantar92@posteo.net>
> Cc: 59603-done@debbugs.gnu.org
> Date: Sat, 26 Nov 2022 09:04:22 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> (defmacro ucs-normalize-string (ucs-normalize-region)
> >> `(with-temp-buffer
> >> (insert str)
> >> (,ucs-normalize-region (point-min) (point-max))
> >> (buffer-string)))
> >>
> >> It apparently uses undefined variable `str', which does not look right.
> >
> > It's a macro, not a function. So STR could come from the code which calls
> > the macro. Look how it is used in that file, and you will see what I mean.
>
> I understand. But this macro is not private (no --). I feel like using
> "str" there is a questionable code style.
It's too late to change that: this macro is very old and predates the --
conventions.
> >> Also, no docstring.
> >
> > I added a doc string.
>
> Thanks! The new docstring implies that STR is an argument, doesn't it?
It doesn't.
next prev parent reply other threads:[~2022-11-26 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 8:41 bug#59603: 28.1.90; `ucs-normalize-string' fails to work Ihor Radchenko
2022-11-26 8:57 ` Eli Zaretskii
2022-11-26 9:04 ` Ihor Radchenko
2022-11-26 9:23 ` Eli Zaretskii [this message]
2022-11-26 9:37 ` Ihor Radchenko
2022-11-26 10:10 ` Eli Zaretskii
2022-11-26 10:16 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6ymt6fs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59603@debbugs.gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).