From: Eli Zaretskii <eliz@gnu.org>
To: Bastian Beranek <bastian.beischer@gmail.com>,
Richard Hansen <rhansen@rhansen.org>
Cc: 60066@debbugs.gnu.org
Subject: bug#60066: 30.0.50; whitespace-mode modifies buffer
Date: Wed, 14 Dec 2022 18:14:56 +0200 [thread overview]
Message-ID: <83h6xym073.fsf@gnu.org> (raw)
In-Reply-To: <877cyuhxj8.fsf@gmail.com> (message from Bastian Beranek on Wed, 14 Dec 2022 15:26:03 +0100)
> From: Bastian Beranek <bastian.beischer@gmail.com>
> Date: Wed, 14 Dec 2022 15:26:03 +0100
>
>
> I have
>
> (add-hook 'c-mode-common-hook 'whitespace-mode)
>
> in my .emacs and I am using emacs master (which includes
> whitespace.el). When opening a source file in my project the buffer
> immediately is marked as modified and emacs will ask to save the buffer
> when trying to kill it.
>
> I was able to trace this back to the above line in my .emacs. If I don't
> enable whitespace-mode in the hook the buffer is not marked as modified
> when opening the .C file.
>
> With my configuration I would not expect whitespace-mode to make any
> changes to the buffer.
>
> I went back to whitespace.el from commit
>
> 29eb4596956a74a83ceb4c17835886a23ea0dd20
>
> and the problem is fixed. So I assume it is a recent regression in
> whitespace.el.
Richard, could you please look into this? It sounds like your recent
changes to whitespace.el could be the culprit for this regression. I
guess something like with-silent-modifications is missing somewhere?
next prev parent reply other threads:[~2022-12-14 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 14:26 bug#60066: 30.0.50; whitespace-mode modifies buffer Bastian Beranek
2022-12-14 16:14 ` Eli Zaretskii [this message]
2022-12-14 16:53 ` Bastian Beranek
2022-12-14 17:02 ` Eli Zaretskii
2022-12-15 0:31 ` Michael Heerdegen
2022-12-19 4:45 ` Richard Hansen
2022-12-19 10:13 ` Bastian Beranek
2022-12-19 13:46 ` Eli Zaretskii
2022-12-19 13:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6xym073.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60066@debbugs.gnu.org \
--cc=bastian.beischer@gmail.com \
--cc=rhansen@rhansen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).