From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: michael_heerdegen@web.de, mail@daniel-mendler.de, 60758@debbugs.gnu.org
Subject: bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring
Date: Sat, 14 Jan 2023 18:35:22 +0200 [thread overview]
Message-ID: <83h6wt6pmd.fsf@gnu.org> (raw)
In-Reply-To: <878ri5krrd.fsf@melete.silentflame.com> (message from Sean Whitton on Sat, 14 Jan 2023 09:25:26 -0700)
> Cc: Daniel Mendler <mail@daniel-mendler.de>, 60758@debbugs.gnu.org,
> 60758-done@debbugs.gnu.org
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Sat, 14 Jan 2023 09:25:26 -0700
>
> > So it makes no sense to add this syntax to newly introduced macros. We
> > should fix the docstring of `while-let' instead - unless the goal of
> > getting rid of this syntax has changed. But then we should have a
> > discussion first. Instead it seems you just reverted a change by Lars
> > that was the result of a discussion in emacs-dev.
>
> Are you saying there was a while-let-specific discussion?
>
> I did vc-annotate and saw that the code I was changing was in the first
> commit of the new macro.
Then something went wrong with vc-annotate, because that code was
modified in commit 0e72d4793c, on Sep 29, the day after the first
commit of this macro.
next prev parent reply other threads:[~2023-01-14 16:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 19:21 bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring Daniel Mendler
2023-01-13 0:37 ` Sean Whitton
2023-01-13 5:36 ` Daniel Mendler
2023-01-14 15:31 ` Michael Heerdegen
2023-01-14 15:35 ` Daniel Mendler
2023-01-14 16:11 ` Michael Heerdegen
2023-01-14 16:29 ` Daniel Mendler
2023-01-14 16:25 ` Sean Whitton
2023-01-14 16:35 ` Eli Zaretskii [this message]
2023-01-14 21:13 ` Sean Whitton
2023-01-14 22:13 ` Michael Heerdegen
2023-01-15 7:38 ` Eli Zaretskii
2023-01-15 17:02 ` Sean Whitton
2023-01-16 17:55 ` Michael Heerdegen
2023-01-16 20:36 ` Sean Whitton
2023-01-17 12:46 ` Michael Heerdegen
2023-01-14 16:58 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6wt6pmd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60758@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
--cc=michael_heerdegen@web.de \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).