From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Wed, 15 Feb 2023 16:10:00 +0200 Message-ID: <83h6vnaukn.fsf@gnu.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> <83ttzsk6v4.fsf@gnu.org> <83wn4le8s3.fsf@gnu.org> <0f053182b02103503c26@heytings.org> <83pmaccnz7.fsf@gnu.org> <0f053182b04357300cb1@heytings.org> <83lel0chku.fsf@gnu.org> <0f053182b00a59a41caa@heytings.org> <835yc3cdhk.fsf@gnu.org> <9e9ed8043fc8bfe49bfe@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17550"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 15:11:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSIVD-0004Py-44 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 15:11:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSIUy-0000uP-92; Wed, 15 Feb 2023 09:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSIUw-0000s8-IA for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 09:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSIUw-0001wG-8v for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 09:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSIUw-0004K4-4E for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 09:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167647023716553 (code B ref 56682); Wed, 15 Feb 2023 14:11:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 15 Feb 2023 14:10:37 +0000 Original-Received: from localhost ([127.0.0.1]:58323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIUX-0004Iu-5q for submit@debbugs.gnu.org; Wed, 15 Feb 2023 09:10:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIUS-0004IZ-PX for 56682@debbugs.gnu.org; Wed, 15 Feb 2023 09:10:35 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSIUK-0001jY-SK; Wed, 15 Feb 2023 09:10:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+DpynauMn32lwXH6RDm6M0cAuiJPh1wB+jlPJdttVGA=; b=maSbHxDetIP7 SgnEfOBqwPVkNVx0JtC5igbQsS7DYeo8yN/+6ZY/GzvHGsjZmnDN2N0UToghrXnayqVpGXsidgqTM +CDsBBYhFQ3m8p629Q4VHP5XcQiklGV2I/QCIDtFz8fOGI0x6JNIZOs7VjDvDmbDkCs0qFDqbKV9h 1drqpbYzYsInvKeRrE0ykRopx0WmyVbr4NNb2gNsJ96auHSfFsotiva6fi5oJTNrKqLuwLqyDpNDT MgZOhOw3oUoR7/vOOenGFC2wtCxOQQQBIGSB1z5buvxTazsPoeFv/H5AL0e4uTon75f/9BTgyYsV5 4xjRQRBS3GX+jFpDvnfW2w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSIUF-0007tp-E2; Wed, 15 Feb 2023 09:10:24 -0500 In-Reply-To: <9e9ed8043fc8bfe49bfe@heytings.org> (message from Gregory Heytings on Wed, 15 Feb 2023 13:37:46 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255710 Archived-At: > Date: Wed, 15 Feb 2023 13:37:46 +0000 > From: Gregory Heytings > cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org > > > Hmm... I'm probably missing something, but doesn't > > narrowing_locks_remove permanently removes the lock from the restriction > > in the buffer? And if so, don't we want to restore the lock after > > whatever we need to do in a widened buffer is done? > > Yes: that's what the "record_unwind_protect (save_restriction_restore, > save_restriction_save ());" does. So save_restriction_restore will reinstate the buffer in the narrowing_locks list? > The two places where 'narrowing_locks_remove_in_current_buffer' is > not preceded by that statement are the two places where we indeed > don't want to restore the restrictions after widening: Ferase_buffer > and Fcall_process_region. OK.