From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 62734@debbugs.gnu.org, leo.gaskin@le0.gs
Subject: bug#62734: Always fully rebuild autoloads in package-generate-autoloads
Date: Sun, 30 Apr 2023 13:08:31 +0300 [thread overview]
Message-ID: <83h6sxptr4.fsf@gnu.org> (raw)
In-Reply-To: <87jzxtg25f.fsf@posteo.net> (message from Philip Kaludercic on Sun, 30 Apr 2023 09:17:16 +0000)
> From: Philip Kaludercic <philipk@posteo.net>
> Cc: leo.gaskin@le0.gs, 62734@debbugs.gnu.org
> Date: Sun, 30 Apr 2023 09:17:16 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> > What happens if a package has no autoloads? The doc string says in
> >> > that case passing EXTRA-DATA will produce OUTPUT-FILE regardless.
> >> > Does your patch handle that? (It's hard to tell, given all the
> >> > whitespace changes in the patch.)
> >>
> >> It would, as the else-case of the if branch I am proposing to eliminate
> >> would still insert the EXTRA-DATA.
> >
> > And if EXTRA-DATA is nil, then will we generate an empty OUTPUT file?
>
> No, we still generate the right file with the right information (in this
> case just a `register-definition-prefixes' invocation).
OK, thanks. Then please make sure this change survives both a
bootstrap and a "normal" build (where a bunch of *.el files need their
autoloads updated), and if so, please install on the emacs-29 branch.
next prev parent reply other threads:[~2023-04-30 10:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 21:16 bug#62734: Always fully rebuild autoloads in package-generate-autoloads Leo Georg Gaskin
2023-04-23 13:16 ` Philip Kaludercic
2023-04-23 14:36 ` Leo Gaskin
2023-04-25 12:35 ` Philip Kaludercic
2023-04-28 15:00 ` Philip Kaludercic
2023-04-28 15:48 ` Eli Zaretskii
2023-04-28 18:00 ` Philip Kaludercic
2023-04-28 18:11 ` Eli Zaretskii
2023-04-28 18:22 ` Philip Kaludercic
2023-04-29 5:43 ` Eli Zaretskii
2023-04-29 8:19 ` Philip Kaludercic
2023-04-29 10:32 ` Eli Zaretskii
2023-04-29 11:18 ` Philip Kaludercic
2023-04-29 12:21 ` Eli Zaretskii
2023-04-30 9:17 ` Philip Kaludercic
2023-04-30 10:08 ` Eli Zaretskii [this message]
2023-04-30 16:45 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6sxptr4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62734@debbugs.gnu.org \
--cc=leo.gaskin@le0.gs \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).