From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages Date: Mon, 08 May 2023 15:04:11 +0300 Message-ID: <83h6snc9ms.fsf@gnu.org> References: <873547jeig.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21539"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wyuenho@gmail.com, 63338@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 08 14:04:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvzbN-0005LO-72 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 May 2023 14:04:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvzb8-0005cF-SL; Mon, 08 May 2023 08:04:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvzb2-0005Wq-OY for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 08:04:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvzb0-0005R5-Nq for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 08:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvzb0-0002Y1-2g for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 08:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 May 2023 12:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63338 X-GNU-PR-Package: emacs Original-Received: via spool by 63338-submit@debbugs.gnu.org id=B63338.16835473999737 (code B ref 63338); Mon, 08 May 2023 12:04:02 +0000 Original-Received: (at 63338) by debbugs.gnu.org; 8 May 2023 12:03:19 +0000 Original-Received: from localhost ([127.0.0.1]:39490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvzaJ-0002Wy-Gw for submit@debbugs.gnu.org; Mon, 08 May 2023 08:03:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvzaH-0002Wl-7V for 63338@debbugs.gnu.org; Mon, 08 May 2023 08:03:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvzaA-0005Jf-V2; Mon, 08 May 2023 08:03:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U0NbsbOco/N/axs+kKssN6wWuoLyca+FJFPzyNvk3M0=; b=MB6QN22AdKRv j3oA9dMIQhSc9CLdHQygVMLI3U6uQqijM/2L8mQJFTP/tDXf6ZM3aQiZVjRt/tJaTQTHHZkOuY1fu VH2FIwCIRce26nquecTiGLYqaRqA6FFk/zb38MB+rpQ1wNkEVyouiPG+5guGiW+1p1wdkkLN72KEp 33Xp6BqO+xjNfXTF9LrTCF1AjNsL2jpNajFYa6uEuRnUc/I3815ZckVnH9j/bXX9BOgDojVEMxx9J tev58wzWJcgXxqA6DQKGqiOC543bron7Gp2OpX5vd/EKTGOKZBaTIx1qHBi9AkqN9I0JFpDMMlyQP 6FFMc/+UEIZKLrRKw5F2SA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvzaA-0002Bb-EH; Mon, 08 May 2023 08:03:10 -0400 In-Reply-To: <873547jeig.fsf@posteo.net> (message from Philip Kaludercic on Mon, 08 May 2023 10:36:55 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261313 Archived-At: > Cc: 63338@debbugs.gnu.org > From: Philip Kaludercic > Date: Mon, 08 May 2023 10:36:55 +0000 > > Jimmy Yuen Ho Wong writes: > > > Reproduction: > > > > 0. (setq custom-file (const user-emacs-directory "custom.el")) > > 1. M-x package-vc-install company > > 2. M-x package-vc-install company RET y > > 3. C-x C-f ~/.emacs/custom.el > > 4. Observe that `company` has been listed twice under > > `package-selected-packages`. > > > > Expectation: > > > > Installing the same package twice should not result in its duplication > > in `package-selected-packages`. > > An easy fix would be just to ensure that package-selected-packages is > always deduplicated before assigning the value: This is OK for the emacs-29 branch, thanks.