From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Date: Thu, 08 Jun 2023 12:15:49 +0300 Message-ID: <83h6ri2u2i.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21348"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63956@debbugs.gnu.org To: Jeff Norden , Sam Steingold Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 08 11:16:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7Bkw-0005PT-SN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jun 2023 11:16:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7Bkb-0004Pw-MZ; Thu, 08 Jun 2023 05:16:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7BkR-0004Jy-3d for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 05:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7BkQ-0006A3-RO for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 05:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7BkQ-00077A-BK for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 05:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 09:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs Original-Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168621576027326 (code B ref 63956); Thu, 08 Jun 2023 09:16:02 +0000 Original-Received: (at 63956) by debbugs.gnu.org; 8 Jun 2023 09:16:00 +0000 Original-Received: from localhost ([127.0.0.1]:55667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7BkL-00076d-91 for submit@debbugs.gnu.org; Thu, 08 Jun 2023 05:16:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7BkF-00076I-RM for 63956@debbugs.gnu.org; Thu, 08 Jun 2023 05:15:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Bk9-00065F-E7; Thu, 08 Jun 2023 05:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+Vpj2MqG3OndbzvGU98qGKjoYizctYmUBweTdTiBc10=; b=c9coZxKyqUQV Rj2wXF6RLRQo2WAE1SIWFcCYvQ5Ve3kHRK4LH2R3I+IWO9r8QBTKS5AJJTuv7v2rONsokut23AVBu t/pbdbK9xeqktSVDICpF+Jt7uH8Z5Y7DBZPWea52Po6WnDU5SlRLwafx6hASQvL3EW+FqBSB4M39Z OX/GhK2DlMuOtZZt7v0HXn8L5T4OKK2IXtTfWAhb9dC7m3o8pdJZ6rzP/hzgyvV9JNfTTjtkBr1t+ HYxJpem29rq9M9QidiK3l2Cjkdi8ru+GaOPJS+EXra7C5x23cO8Tc0bh21I8EowkEnEywRjm9IRSo GlAP5V+i9fG6o0AZWepq+Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Bk7-00036x-Sv; Thu, 08 Jun 2023 05:15:45 -0400 In-Reply-To: (message from Jeff Norden on Wed, 7 Jun 2023 12:52:10 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263113 Archived-At: > From: Jeff Norden > Date: Wed, 7 Jun 2023 12:52:10 -0500 > > I've been trying out the 2nd emacs-29 pretest. It seems great. > I haven't needed to tweak a single line of my .emacs or any of the > custom files it loads (about 1200 lines in all). The new > 'with-restriction' feature may simplify a project that I've been > playing with for a while. > > However, I have found a minor issue with a change made to tex-mode. > The simple calls to `display-buffer' in tex-mode.el have been replaced > with: > (display-buffer tex-shell display-comint-buffer-action) > The default value for display-comint-buffer-action is set from > display-buffer--same-window-action. > > As a result, the default behavior of `tex-buffer' or `tex-region' is > that the document you are editing *disappears*, and and the window it > was displayed in shows just the error messages (or lack thereof) from > running TeX. You then need to switch back to the document's buffer to > continue editing. This behavior makes no sense. It would be > equivalent to running `compile' on a C file, and then only seeing the > output from make/gcc/etc, with the source code hidden. The correct > behavior in both cases is to show the process output in a window > alongside the source. Anyone who has been using tex-mode for years > would certainly find this new behavior disruptive, although it is > easily corrected. > > I'm not sure if the `display-buffer' calls in tex-mode.el need to have > an action argument, but if they do, it should be similar to what is > used in compile.el. I'll be the first to admit that I'm not > particularly well-versed in the current intricacies of buffer display > actions (nor do I have any real desire to become so :-). Adding Sam, who made these changes in tex-mode.el. Sam, any comments? Jeff, would you please look at the 3 places in tex-mode where display-comint-buffer-action was added to calls to pop-to-buffer and display-buffer, and tell in which ones showing the buffer in the same window by default makes sense? I don't myself use tex-mode, so it is hard for me to tell. We could then discuss whether to remove the argument in some of the cases or make a tex-mode-specific user option to let users control that. For example, in the specific case of tex-display-shell it sounds like just dropping the argument would be TRT, since all of its callers want to show the shell buffer, but not in the selected window. What about the other two cases where this argument was added? Thanks.