From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62606: [PATCH] function to align mode-line elements to right Date: Fri, 09 Jun 2023 17:52:24 +0300 Message-ID: <83h6rg1ydz.fsf@gnu.org> References: <83355iygw3.fsf@gnu.org> <83mt2hfrr4.fsf@gnu.org> <4b872ecc12e3995d5b7dfffa580e297d@heagren.com> <83zg5c3kbo.fsf@gnu.org> <83ilbw22zh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12626"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62606@debbugs.gnu.org To: hugo@heagren.com, Stefan Monnier , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 09 16:53:56 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7dUy-000311-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Jun 2023 16:53:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7dUf-0005jZ-Um; Fri, 09 Jun 2023 10:53:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7dU6-0005YL-Oi for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 10:53:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7dU6-000156-Gd for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 10:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7dU6-0004Qj-C6 for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 10:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62606-submit@debbugs.gnu.org id=B62606.168632235316987 (code B ref 62606); Fri, 09 Jun 2023 14:53:02 +0000 Original-Received: (at 62606) by debbugs.gnu.org; 9 Jun 2023 14:52:33 +0000 Original-Received: from localhost ([127.0.0.1]:60012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7dTd-0004Pv-7N for submit@debbugs.gnu.org; Fri, 09 Jun 2023 10:52:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7dTa-0004Pi-Vm for 62606@debbugs.gnu.org; Fri, 09 Jun 2023 10:52:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7dTT-0000zO-W9; Fri, 09 Jun 2023 10:52:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SY5ACzveidzG8DSp3OiJV/iHBrJoiV2CLQWbQihqTAs=; b=Pq06f84MKepe BPyvtsZWzdGx3iW8FfHbIVPyIieHz+a8oseSAtFe4A6aBCXpZ/WBXK/CBxeU5iyRuwP8ySMG1xGkP dTwhLSqCJwfF4xb/77VRWb2V25q1GqGDJZP3kDabgNefcZUJgVJ/Fwi84Z8eWa7ytTiypk4HHfK2s SdywrdIm3HPKcyLKwmTqF5UtK+VUMBVPXBxE2tiAXx8tfJ1dYspuIEdpAnb5V0QLjV/tRyUW4CgSq NcFTZs2tdAv3K+E6B2GfjesI8+f7YpAbXPU9Ar4h7LyD5IJ0WfURhBxeBmCyZmhaS+DxiPEN0n+Mo 4TFbxvcGkCgMyvGOlfcN6A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7dTM-0005kx-5H; Fri, 09 Jun 2023 10:52:23 -0400 In-Reply-To: (hugo@heagren.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263167 Archived-At: > Date: Fri, 09 Jun 2023 15:28:36 +0100 > From: hugo@heagren.com > > On 2023-06-09 14:13, Eli Zaretskii wrote: > > You can accomplish that by padding, even without right-alignment, I > > think. > > Yes you can. I just prefer how right-alignment looks. You can even think > of right-alignment as ane extreme case of padding, if > > >> Overall, I can see that this isn't a feature you like, and probably > >> not > >> one you would use either, but it's similar enough (in function and in > >> problems) to other stuff already in Emacs > > > > Sadly. > > Since you don't agree with the general implementation or function of > this patch, I don't think I'm going to be able to do anything to make it > more acceptable for you. > > I've fixed all the technical issues which have been pointed out (except > the thing about calling `string-pixel-width', that's way beyond my > skills atm). Clearly some people (whoever wrote and now uses > `tab-bar-format-align-right') like features like this, so I think this > is worth merging, in basically the state its in now. If you don't > though, I'm happy to publish it as a separate package. What do you > think? Let's hear from others. Stefan, Lars, any thoughts? Does anyone else have any comments about this proposed feature? In any case, before we accept this, it must be documented and called out in NEWS. Also, the defcustom should have a :version tag.