From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval Date: Sat, 15 Jul 2023 11:57:06 +0300 Message-ID: <83h6q5d02l.fsf@gnu.org> References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> <87edlcc3ms.fsf@posteo.net> <87fs5qp9bk.fsf@posteo.net> <83mszxenby.fsf@gnu.org> <87mszx62su.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33096"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 64543@debbugs.gnu.org, sbaugh@catern.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 10:57:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKb5f-0008QJ-Sn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 10:57:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKb5L-0001cb-ME; Sat, 15 Jul 2023 04:57:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKb5K-0001Y7-3s for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 04:57:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKb5J-0007w3-Rl for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 04:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKb5J-0003Pc-Nt for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 04:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64543-submit@debbugs.gnu.org id=B64543.168941141613104 (code B ref 64543); Sat, 15 Jul 2023 08:57:01 +0000 Original-Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 08:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:44123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKb5D-0003PI-IQ for submit@debbugs.gnu.org; Sat, 15 Jul 2023 04:56:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKb5A-0003P4-83 for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 04:56:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKb54-0007uy-NH; Sat, 15 Jul 2023 04:56:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KJhkykdMPpWx5K8WWezFJ1EjxZXvgQzjueNpB2w1RRs=; b=WZ7An6Bmk1yS njvuHXh+cJJRdLvd6IXoMQqiz9Tnf4kPt1c/NSCdOEz0btoqeuRt2qAqz2nJcWjoSw7WG5P9WrJq2 rJmSVYJ1Ws7DBDBh21ejhcfL5towImpPRDkFdWICdrc4u16E7xVPNK7ayvsdExQmtg9yc5CfT6DJ7 AyBwbRppnYlvi3gdOwpQ3Rc3mSvkgB75zyXLorHLR1iSyYmzHUBnPUQqrdCHvwfdK0ZuGqRvNkLQF NXjXWLmCFztN1GXl83OkgWDY75d5+4GyaeLvhqLq16v4GsjkSQoOdUfssv6jKTSKhFnUB5JSc/y64 Ljl9ZrceMoCf5t8NLOD7rg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKb54-0001Pp-70; Sat, 15 Jul 2023 04:56:46 -0400 In-Reply-To: <87mszx62su.fsf@posteo.net> (message from Philip Kaludercic on Sat, 15 Jul 2023 07:40:01 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265176 Archived-At: > From: Philip Kaludercic > Cc: sbaugh@janestreet.com, sbaugh@catern.com, 64543@debbugs.gnu.org > Date: Sat, 15 Jul 2023 07:40:01 +0000 > > Eli Zaretskii writes: > > >> Eli, would it be OK to push this to emacs-29, as this is a bug in the > >> existing code? Most of the changes are indentation/whitespace changes > >> anyway. > > > > I don't understand the cases in which this bug happens, and so cannot > > make the decision. > > Spencer gave this example: > > >> Previously we just assumed that the car of an element of > >> custom-current-group-alist was a filename. But actually it can be nil > >> if a custom group was defined by just evaling Lisp. > > > > Where is this behaviour documented? I couldn't reproduce it with a > > simple experiment. > > To reproduce: > M-: (defgroup mygroup nil "my group") RET > > The patch would ensure that if groups like these are defined (which > might happen by mistake), then `package-report-bug' will remain robust > and not fail due to a unrelated issue. Is this case important enough to make this change so late in the pretest? Spencer, how did you bump into this situation in Real Life?