From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64647: Re: bug#64647: treesit-query-error due to a recent change to tree-sitter-javascript grammar definition Date: Sun, 16 Jul 2023 21:19:38 +0300 Message-ID: <83h6q390sl.fsf@gnu.org> References: <2171209.irdbgypaU6@fedora> <83351obfqw.fsf@gnu.org> <87lefgdzea.fsf@thornhill.no> <1861187.tdWV9SEqCh@fedora> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36565"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64647@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 20:20:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL6M2-0009LG-HG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 20:20:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL6Lk-0003Tp-0F; Sun, 16 Jul 2023 14:20:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL6Li-0003Rv-F7 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 14:20:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL6Li-0004is-7G for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 14:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL6Lh-0000Py-LS for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 14:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64647 X-GNU-PR-Package: emacs Original-Received: via spool by 64647-submit@debbugs.gnu.org id=B64647.16895315631523 (code B ref 64647); Sun, 16 Jul 2023 18:20:01 +0000 Original-Received: (at 64647) by debbugs.gnu.org; 16 Jul 2023 18:19:23 +0000 Original-Received: from localhost ([127.0.0.1]:48530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL6L4-0000OU-TI for submit@debbugs.gnu.org; Sun, 16 Jul 2023 14:19:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL6L2-0000OA-Vs for 64647@debbugs.gnu.org; Sun, 16 Jul 2023 14:19:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL6Kw-0004bX-GO; Sun, 16 Jul 2023 14:19:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N8GaDhQfCL4AdCs70i6qs3bXSI+jXQkOf6ScX53XrA4=; b=nzDpu2uw3HGS Kh7TIgECzFaYNDh2oszmIt/PwahYbqHpQeMc5iGHMu1DgTEIlaPU/LzLKLZ/IzyOdT+LgK7RLcKx0 4ova0UYaRZdQ6gCPYGbbGn04SLzxBIrWwEwJCuNMzbXpe7Y3jtT4zsAFzTQKnFG98KeHzTsErvsgQ TXy7jQWdSKWz++ldsPl8udaYo4J8BcH8ocNfmp83jbAKltETRgOU1ToBnTBl2JOPLztYeeyJp0jI5 y52nxfUVF7jOy29GVzhTwJAkyUJzqmWZLCmzZxTXoDy1n8oOhrp8HuNqUCb8PC9WbOL6LEGM7njbT u+JGR8PaJoJpTr5aURLKNA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL6Kw-0004ev-0Y; Sun, 16 Jul 2023 14:19:14 -0400 In-Reply-To: <1861187.tdWV9SEqCh@fedora> (message from Vincenzo Pupillo on Sun, 16 Jul 2023 20:00:43 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265357 Archived-At: > From: Vincenzo Pupillo > Cc: 64647@debbugs.gnu.org, jostein@kjonigsen.net > Date: Sun, 16 Jul 2023 20:00:43 +0200 > > In my patch for java-ts-mode I used treesit-query-capture to figure out whether > a symbol was defined or not. Check out the java-ts-mode--string-highlight- > helper function. Can you do something similar in this case? That would be good enough for Emacs 29.1. > > Vincenzo, do you want to add compat-code to emacs-29 and your patches? > > Okay. I think I can do it this week. Do I create a new file, like treesitter- > compat.el ? This should be for master, I think. I'd like to release Emacs 29.1 soon, so this more general job should be less urgent than fixing the typescript modes to work with the latest grammars. Thanks.