From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Fri, 04 Aug 2023 18:27:55 +0300 Message-ID: <83h6pevnd0.fsf@gnu.org> References: <83leeqvpx8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33453"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org, acm@muc.de To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 17:28:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRwj2-0008U3-96 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 17:28:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRwiq-0004BJ-08; Fri, 04 Aug 2023 11:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwim-00048G-P9 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 11:28:09 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRwig-0003uh-Ej for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 11:28:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRwig-0002ha-AT for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.169116286910362 (code B ref 65051); Fri, 04 Aug 2023 15:28:02 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 4 Aug 2023 15:27:49 +0000 Original-Received: from localhost ([127.0.0.1]:54585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwiT-0002h4-Co for submit@debbugs.gnu.org; Fri, 04 Aug 2023 11:27:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwiS-0002gr-Gc for 65051@debbugs.gnu.org; Fri, 04 Aug 2023 11:27:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwiN-0003pj-1g; Fri, 04 Aug 2023 11:27:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=On9PlJujmw7fSrlFQxK4jF2ESTZwSqehL8yMCWr4ACY=; b=I4RqH/SAyFVe QXwsIKAlP7v+DTnmUN9tVxYHqGcGFIODjYlpojM84uvr1UvkevrgZ/QiYOH6rvygUwFA5DQXYeyBF fQGCuw5vHJdyxMbhIoOQC3vyGxTWcXZZ4FBGQ9AikhqyLaHlhrN23QvruO5stFuD8Fc8DUd0lh9Hb SgZCKy6cKeGlzDsco4UlS9KfuhPLJ5GflQuzK1I2pleKnH+0XJy1dHg1tdtbBJhshV5fWxE8YNzcp KzusZufxxgQiaVq5grmqK1Vxm1PJwkvGES1GNSDaTTjL/G5yyCpKCdkF1tLJuZYz46s1H9f4GjuEg lg0SzwDsprgpse/MCr8sng==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwiM-0002UD-HO; Fri, 04 Aug 2023 11:27:42 -0400 In-Reply-To: (message from Alan Mackenzie on Fri, 4 Aug 2023 14:59:58 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266689 Archived-At: > Date: Fri, 4 Aug 2023 14:59:58 +0000 > Cc: 65051@debbugs.gnu.org, acm@muc.de > From: Alan Mackenzie > > > What will happen to the comparison in internal_equal when > > symbols_with_pos_enabled is zero and the two objects have different > > positions, or one has a position, the other doesn't? > > In these cases, equal will return nil. This is correct. It is? I thought when symbols with position are disabled, symbols that are 'eq', but have different positions, should compare equal? Why not? > In the other case, when two symbols with position have the same base > symbol and the same position, yet aren't identical, this will also return > nil, which is incorrect. How can they be not identical if the symbols and the positions are the same? Or maybe I don't understand what you mean by "base symbol"? > > And which branch are you proposing this change for? > > master. It doesn't seem important enough for the release branch. OK.