From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67046: 29.1.50; map-y-or-n-p infinite loops if it's at the end of a kmacro Date: Wed, 15 Nov 2023 14:02:52 +0200 Message-ID: <83h6lnrzpv.fsf@gnu.org> References: <83il69xwsr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34502"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 67046@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 17:30:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3Imr-0008lf-Nk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 17:30:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3IlH-0002TK-7F; Wed, 15 Nov 2023 11:29:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3IlE-0002Rf-KR for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:29:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3IlE-0006AR-Cd for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:29:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3IlD-0002An-Es for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:29:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 16:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67046 X-GNU-PR-Package: emacs Original-Received: via spool by 67046-submit@debbugs.gnu.org id=B67046.17000656918229 (code B ref 67046); Wed, 15 Nov 2023 16:29:03 +0000 Original-Received: (at 67046) by debbugs.gnu.org; 15 Nov 2023 16:28:11 +0000 Original-Received: from localhost ([127.0.0.1]:53130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IkM-00028Z-FU for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:28:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IQj-0001QS-U8 for 67046@debbugs.gnu.org; Wed, 15 Nov 2023 11:07:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Ebn-0000cF-Td; Wed, 15 Nov 2023 07:03:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Q8/JNGr9nHNhNvhcc6d08xb7qiVdNYDkJln3SP8zTZM=; b=Sz/7+IgfhgQv EyMuElJzGu2WkGf8U9IhxvfPVEZGNxq455O3WcSoJnNNpBFeqev2bqqKVOSEGNzZlbTgQP8wAgLSw W7SBwSWJ8OJYdbuAJfNTos4KQdXut9rGTkIOazCAgaoWAkh4OiqVqTOSxGmAdQJidxkV+8B8JLs7I B6kXgOkpqzME7nIZJz5fAhiQiolNj5KFz63d7ZdCo9WrX+Nix4qZQuCiziaoy9sLlkC0QLO+/tYRY NzPrGbuIQCm95sChzpKZXt17gpTTNNHps5aqhZU/bkAFqzUQyUpUyXPHq1yq36/hnCQDcribQCuRG T/XXWYSvk5zv8zvMShBDMw==; In-Reply-To: (message from Stefan Monnier on Tue, 14 Nov 2023 17:09:45 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274382 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 67046@debbugs.gnu.org > Date: Tue, 14 Nov 2023 17:09:45 -0500 > > >> How can we be sure this doesn't introduce some regression? > > I'm not certain, but the behavior as written is a completely inert > > infinite loop, just sitting and spamming read-event over and over > > forever and maxing out the CPU. It seems hard for this to be correct > > behavior. > > Agreed. > > >> Do you understand why this loop was added, in commit 3f72fac865? > > I do not. > > Neither do I. The handling of keyboard macro wasn't very different from > what we have now, so by my reading of the code it suffered from the same > inf-loop as the one we're discussing. > > I see that Gerd fixed that commit a week later by removing a `not` which > strongly suggests the code wasn't tested very much, if at all. > > > Maybe this was some kind of XEmacs confusion? I don't know the full > > history of keyboard macros, but perhaps in XEmacs read-event would start > > returning keyboard input again after starting to return -1. (In GNU > > Emacs, AFAICT, it's always been the case that read-event returns -1 > > forever after we run out of input in the keyboard macro, but haven't yet > > actually returned from the command loop) > > Reading the code I'm wondering how come we don't get into inf-loops > more often when executing macros that stop in the middle of a recursive > edit, or minibuffer input, or ... So what is the path forward? Should we install the change on master and cross our fingers?