unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 67533@debbugs.gnu.org, jdtsmith@gmail.com
Subject: bug#67533: SVG images confound position pixel measurements
Date: Fri, 01 Dec 2023 16:55:47 +0200	[thread overview]
Message-ID: <83h6l29dl8.fsf@gnu.org> (raw)
In-Reply-To: <87ttp2ugsk.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 01 Dec 2023 15:40:59 +0100)

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: JD Smith <jdtsmith@gmail.com>,  67533@debbugs.gnu.org
> Date: Fri, 01 Dec 2023 15:40:59 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Does the patch below fix the issue?  (It should fix the recipe you
> > posted, but you hinted that this is just the simplest way of seeing a
> > more general problem, so I wonder whether that more general problem is
> > also fixed.)
> 
> Hi,
> 
> I have applied your patch to master and here are the results I get with
> the recipe at the end of this message:
> 
> With a not large enough window:
>   FIRST LINE: (925 24 1); ABOVE IMAGE: (925 24 119)
> 
> With a large enough window (i.e., that can display the whole first
> line):
>   FIRST LINE: (1053 24 1); ABOVE IMAGE: (1062 24 119)

If you think these results still show a problem, please elaborate.
Since you did this on your system, with your fonts and frame
dimensions, I cannot know whether the numbers are correct or not.

The patch I posted is supposed to fix only one issue: the fact that
the Y-dimension of the line above the image was shown as zero.  AFAIU,
it is indeed not zero in the output you show above.

Btw, I wonder what you and JD expect from the (cons (point) -1)
argument.  The doc string says:

  If FROM is a cons, its car specifies a buffer position, and its cdr
  specifies the vertical offset in pixels from that position to the
  first screen line to be measured.

What is the meaning of negative offset from the first line of the
buffer? there's no screen line at that offset, so what do you expect
that to do?  Or what am I missing?





  reply	other threads:[~2023-12-01 14:55 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E44B7B4B-8FE9-41EB-BF7B-93AC5EAEAC07@gmail.com>
2023-11-29 20:31 ` bug#67533: SVG images confound position pixel measurements JD Smith
2023-11-30 17:32   ` Eli Zaretskii
2023-11-30 21:00     ` JD Smith
2023-12-01  7:08       ` Eli Zaretskii
2023-12-01 22:04         ` JD Smith
2023-12-02  7:30           ` Eli Zaretskii
2023-12-02 13:36             ` JD Smith
2023-12-02 14:18               ` Eli Zaretskii
2023-12-02 19:39                 ` Eli Zaretskii
2023-12-02 21:44                   ` JD Smith
2023-12-03  3:04                     ` JD Smith
2023-12-03 13:02                       ` Eli Zaretskii
2023-12-03 15:48                         ` JD Smith
2023-12-03 15:52                           ` Eli Zaretskii
2023-12-03 16:31                             ` Eli Zaretskii
2023-12-03 21:25                               ` JD Smith
2023-12-03 23:14                                 ` JD Smith
2023-12-04  3:27                                 ` Eli Zaretskii
2023-12-04  4:32                                   ` JD Smith
2023-12-04 13:11                                     ` Eli Zaretskii
2023-12-04 14:14                                       ` JD Smith
2023-12-16  9:32                                         ` Eli Zaretskii
2023-12-16 15:07                                           ` JD Smith
2023-12-16 15:23                                             ` Eli Zaretskii
2023-12-03 15:49                         ` JD Smith
2023-12-03 16:33                           ` Eli Zaretskii
2023-12-03 18:58                             ` JD Smith
2023-12-01 14:40     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-01 14:55       ` Eli Zaretskii [this message]
2023-12-01 15:21         ` JD Smith
2023-12-01 15:36           ` Eli Zaretskii
2023-12-01 15:45             ` JD Smith
2023-12-01 15:59               ` Eli Zaretskii
2023-12-01 16:17                 ` JD Smith
2023-12-01 16:30                   ` Eli Zaretskii
2023-12-01 16:27         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-01 16:31           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6l29dl8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=67533@debbugs.gnu.org \
    --cc=jdtsmith@gmail.com \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).